Enable _api_features.json to block APIs from service worker contexts.

Enable _api_features.json to block APIs from service worker contexts.

A new property blocked_in_service_worker is parsed from features
and exposed via IsBlockedInServiceWorker().

BUG=350009
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260716

[not at google - send to devlin, 2014-03-28 17:30:48]

lgtm

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/features/complex_feature.cc (right):

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature.cc:13: // Verify
IsBlockedInServiceWorker is consistent across all features.
cool, good idea. Any chance you do the same for GetContexts and IsPrivate? They
suffer from the same problem.

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/features/complex_feature_unittest.cc (right):

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature_unittest.cc:175:
scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
allocate on stack?

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature_unittest.cc:201:
scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
ditto

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature_unittest.cc:207: //
blocked_in_service_worker will DCHECK.
testing DCHECKs isn't that useful. DCHECK means that a fundamental assumption
has been broken somewhere. if it's something that worth dealing with then that's
a different question but I don't think so.

[scheib, 2014-03-28 18:15:21]

thx

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/features/complex_feature.cc (right):

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature.cc:13: // Verify
IsBlockedInServiceWorker is consistent across all features.
On 2014/03/28 17:30:49, kalman wrote:
> cool, good idea. Any chance you do the same for GetContexts and IsPrivate?
They
> suffer from the same problem.

Done.

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/features/complex_feature_unittest.cc (right):

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature_unittest.cc:175:
scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
On 2014/03/28 17:30:49, kalman wrote:
> allocate on stack?

Done.

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature_unittest.cc:201:
scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));
On 2014/03/28 17:30:49, kalman wrote:
> ditto

Done.

https://codereview.chromium.org/217163003/diff/20001/chrome/common/extensions...
chrome/common/extensions/features/complex_feature_unittest.cc:207: //
blocked_in_service_worker will DCHECK.
On 2014/03/28 17:30:49, kalman wrote:
> testing DCHECKs isn't that useful. DCHECK means that a fundamental assumption
> has been broken somewhere. if it's something that worth dealing with then
that's
> a different question but I don't think so.

Done.

[scheib, 2014-03-28 20:27:38]

The CQ bit was checked by scheib@chromium.org

[scheib, 2014-03-28 20:29:04]

The CQ bit was unchecked by scheib@chromium.org

[commit-bot: I haz the power, 2014-03-28 20:29:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/217163003/40001

[scheib, 2014-03-28 20:43:32]

The CQ bit was checked by scheib@chromium.org

[scheib, 2014-03-28 20:43:38]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2014-03-28 20:43:45]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-03-28 20:50:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/217163003/40001

[commit-bot: I haz the power, 2014-03-28 23:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 23:54:35]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[scheib, 2014-03-31 17:47:30]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-03-31 17:48:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/217163003/40001

[commit-bot: I haz the power, 2014-03-31 19:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 19:22:31]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[scheib, 2014-03-31 19:37:54]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2014-03-31 19:38:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/217163003/40001

[commit-bot: I haz the power, 2014-04-01 00:27:26]

Change committed as 260716