chrome/common/extensions/features/simple_feature.cc - Issue 217163003: Enable _api_features.json to block APIs from service worker contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/simple_feature.cc

Issue 217163003: Enable _api_features.json to block APIs from service worker contexts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/features/simple_feature.cc

diff --git a/chrome/common/extensions/features/simple_feature.cc b/chrome/common/extensions/features/simple_feature.cc

index 70aceb34cc5a938de5bde72442585a560aaae6ae..12b1e0f17452e103f214e4713b9c63aaae1efcd0 100644

--- a/chrome/common/extensions/features/simple_feature.cc

+++ b/chrome/common/extensions/features/simple_feature.cc

@@ -489,10 +489,11 @@ std::set<Feature::Context>* SimpleFeature::GetContexts() {

}

bool SimpleFeature::IsInternal() const {

- NOTREACHED();

return false;

}

+bool SimpleFeature::IsBlockedInServiceWorker() const { return false; }

bool SimpleFeature::IsIdInWhitelist(const std::string& extension_id) const {

return IsIdInWhitelist(extension_id, whitelist_);

}