Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2171623002: Revert of Refactor parsing and storage of SkGammas (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Refactor parsing and storage of SkGammas (patchset #8 id:280001 of https://codereview.chromium.org/2117773002/ ) Reason for revert: Tests failing Original issue's description: > Refactor parsing and storage of SkGammas > > Benefits: > (1) Parses and stores gamma tags in a single allocation. > (2) Recognizes equal gamma tags to skip parsing work and > save memory. > > Non-Benefits: > (1) Not less complicated. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117773002 > > Committed: https://skia.googlesource.com/skia/+/2ea944c2b710caf29d4795ac953bad14224796f7 > Committed: https://skia.googlesource.com/skia/+/959ccc1f3f49e1ddeb51c32c30ac4a2d94653856 TBR=reed@google.com,brianosman@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/456bf30d321292da7f15d1af35fd94fbb6a4bb59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+808 lines, -890 lines) Patch
M src/core/SkColorSpace.cpp View 2 chunks +12 lines, -28 lines 0 comments Download
M src/core/SkColorSpacePriv.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkColorSpaceXform.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkColorSpaceXform.cpp View 6 chunks +297 lines, -112 lines 0 comments Download
M src/core/SkColorSpace_Base.h View 2 chunks +119 lines, -109 lines 0 comments Download
M src/core/SkColorSpace_ICC.cpp View 10 chunks +334 lines, -562 lines 0 comments Download
M tests/ColorSpaceXformTest.cpp View 2 chunks +31 lines, -78 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Refactor parsing and storage of SkGammas
4 years, 5 months ago (2016-07-20 23:14:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171623002/1
4 years, 5 months ago (2016-07-20 23:14:08 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 23:14:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/456bf30d321292da7f15d1af35fd94fbb6a4bb59

Powered by Google App Engine
This is Rietveld 408576698