Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: src/core/SkColorSpace.cpp

Issue 2171623002: Revert of Refactor parsing and storage of SkGammas (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/core/SkColorSpacePriv.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkColorSpace.h" 8 #include "SkColorSpace.h"
9 #include "SkColorSpace_Base.h" 9 #include "SkColorSpace_Base.h"
10 #include "SkColorSpacePriv.h" 10 #include "SkColorSpacePriv.h"
11 #include "SkOnce.h" 11 #include "SkOnce.h"
12 12
13 SkColorSpace::SkColorSpace(GammaNamed gammaNamed, const SkMatrix44& toXYZD50, Na med named) 13 SkColorSpace::SkColorSpace(GammaNamed gammaNamed, const SkMatrix44& toXYZD50, Na med named)
14 : fGammaNamed(gammaNamed) 14 : fGammaNamed(gammaNamed)
15 , fToXYZD50(toXYZD50) 15 , fToXYZD50(toXYZD50)
16 , fNamed(named) 16 , fNamed(named)
17 {} 17 {}
18 18
19 SkColorSpace_Base::SkColorSpace_Base(GammaNamed gammaNamed, const SkMatrix44& to XYZD50, Named named) 19 SkColorSpace_Base::SkColorSpace_Base(GammaNamed gammaNamed, const SkMatrix44& to XYZD50, Named named)
20 : INHERITED(gammaNamed, toXYZD50, named) 20 : INHERITED(gammaNamed, toXYZD50, named)
21 , fGammas(nullptr) 21 , fGammas(nullptr)
22 , fProfileData(nullptr) 22 , fProfileData(nullptr)
23 {} 23 {}
24 24
25 SkColorSpace_Base::SkColorSpace_Base(sk_sp<SkColorLookUpTable> colorLUT, GammaNa med gammaNamed, 25 SkColorSpace_Base::SkColorSpace_Base(sk_sp<SkColorLookUpTable> colorLUT, sk_sp<S kGammas> gammas,
26 sk_sp<SkGammas> gammas, const SkMatrix44& t oXYZD50, 26 const SkMatrix44& toXYZD50, sk_sp<SkData> p rofileData)
27 sk_sp<SkData> profileData) 27 : INHERITED(kNonStandard_GammaNamed, toXYZD50, kUnknown_Named)
28 : INHERITED(gammaNamed, toXYZD50, kUnknown_Named)
29 , fColorLUT(std::move(colorLUT)) 28 , fColorLUT(std::move(colorLUT))
30 , fGammas(std::move(gammas)) 29 , fGammas(std::move(gammas))
31 , fProfileData(std::move(profileData)) 30 , fProfileData(std::move(profileData))
32 {} 31 {}
33 32
34 static constexpr float gSRGB_toXYZD50[] { 33 static constexpr float gSRGB_toXYZD50[] {
35 0.4358f, 0.2224f, 0.0139f, // * R 34 0.4358f, 0.2224f, 0.0139f, // * R
36 0.3853f, 0.7170f, 0.0971f, // * G 35 0.3853f, 0.7170f, 0.0971f, // * G
37 0.1430f, 0.0606f, 0.7139f, // * B 36 0.1430f, 0.0606f, 0.7139f, // * B
38 }; 37 };
(...skipping 23 matching lines...) Expand all
62 color_space_almost_equal(toXYZD50.getFloat(0, 3), 0.0f) && 61 color_space_almost_equal(toXYZD50.getFloat(0, 3), 0.0f) &&
63 color_space_almost_equal(toXYZD50.getFloat(1, 3), 0.0f) && 62 color_space_almost_equal(toXYZD50.getFloat(1, 3), 0.0f) &&
64 color_space_almost_equal(toXYZD50.getFloat(2, 3), 0.0f) && 63 color_space_almost_equal(toXYZD50.getFloat(2, 3), 0.0f) &&
65 color_space_almost_equal(toXYZD50.getFloat(3, 0), 0.0f) && 64 color_space_almost_equal(toXYZD50.getFloat(3, 0), 0.0f) &&
66 color_space_almost_equal(toXYZD50.getFloat(3, 1), 0.0f) && 65 color_space_almost_equal(toXYZD50.getFloat(3, 1), 0.0f) &&
67 color_space_almost_equal(toXYZD50.getFloat(3, 2), 0.0f) && 66 color_space_almost_equal(toXYZD50.getFloat(3, 2), 0.0f) &&
68 color_space_almost_equal(toXYZD50.getFloat(3, 3), 1.0f); 67 color_space_almost_equal(toXYZD50.getFloat(3, 3), 1.0f);
69 } 68 }
70 69
71 sk_sp<SkColorSpace> SkColorSpace_Base::NewRGB(float values[3], const SkMatrix44& toXYZD50) { 70 sk_sp<SkColorSpace> SkColorSpace_Base::NewRGB(float values[3], const SkMatrix44& toXYZD50) {
72 if (0.0f > values[0] || 0.0f > values[1] || 0.0f > values[2]) { 71 SkGammaCurve curves[3];
73 return nullptr; 72 set_gamma_value(&curves[0], values[0]);
74 } 73 set_gamma_value(&curves[1], values[1]);
74 set_gamma_value(&curves[2], values[2]);
75 75
76 GammaNamed gammaNamed = kNonStandard_GammaNamed; 76 GammaNamed gammaNamed = SkGammas::Named(curves);
77 if (color_space_almost_equal(2.2f, values[0]) &&
78 color_space_almost_equal(2.2f, values[1]) &&
79 color_space_almost_equal(2.2f, values[2])) {
80 gammaNamed = k2Dot2Curve_GammaNamed;
81 } else if (color_space_almost_equal(1.0f, values[0]) &&
82 color_space_almost_equal(1.0f, values[1]) &&
83 color_space_almost_equal(1.0f, values[2])) {
84 gammaNamed = kLinear_GammaNamed;
85 }
86
87 if (kNonStandard_GammaNamed == gammaNamed) { 77 if (kNonStandard_GammaNamed == gammaNamed) {
88 sk_sp<SkGammas> gammas = sk_sp<SkGammas>(new SkGammas()); 78 sk_sp<SkGammas> gammas(new SkGammas(std::move(curves[0]), std::move(curv es[1]),
89 gammas->fRedType = SkGammas::Type::kValue_Type; 79 std::move(curves[2])));
90 gammas->fGreenType = SkGammas::Type::kValue_Type; 80 return sk_sp<SkColorSpace>(new SkColorSpace_Base(nullptr, gammas, toXYZD 50, nullptr));
91 gammas->fBlueType = SkGammas::Type::kValue_Type;
92 gammas->fRedData.fValue = values[0];
93 gammas->fGreenData.fValue = values[1];
94 gammas->fBlueData.fValue = values[2];
95 return sk_sp<SkColorSpace>(new SkColorSpace_Base(nullptr, kNonStandard_G ammaNamed, gammas,
96 toXYZD50, nullptr));
97 } 81 }
98 82
99 return SkColorSpace_Base::NewRGB(gammaNamed, toXYZD50); 83 return SkColorSpace_Base::NewRGB(gammaNamed, toXYZD50);
100 } 84 }
101 85
102 sk_sp<SkColorSpace> SkColorSpace_Base::NewRGB(GammaNamed gammaNamed, const SkMat rix44& toXYZD50) { 86 sk_sp<SkColorSpace> SkColorSpace_Base::NewRGB(GammaNamed gammaNamed, const SkMat rix44& toXYZD50) {
103 switch (gammaNamed) { 87 switch (gammaNamed) {
104 case kSRGB_GammaNamed: 88 case kSRGB_GammaNamed:
105 if (xyz_almost_equal(toXYZD50, gSRGB_toXYZD50)) { 89 if (xyz_almost_equal(toXYZD50, gSRGB_toXYZD50)) {
106 return SkColorSpace::NewNamed(kSRGB_Named); 90 return SkColorSpace::NewNamed(kSRGB_Named);
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 281
298 uint32_t profileSize = *((uint32_t*) data); 282 uint32_t profileSize = *((uint32_t*) data);
299 data = SkTAddOffset<const void>(data, sizeof(uint32_t)); 283 data = SkTAddOffset<const void>(data, sizeof(uint32_t));
300 length -= sizeof(uint32_t); 284 length -= sizeof(uint32_t);
301 if (length < profileSize) { 285 if (length < profileSize) {
302 return nullptr; 286 return nullptr;
303 } 287 }
304 288
305 return NewICC(data, profileSize); 289 return NewICC(data, profileSize);
306 } 290 }
OLDNEW
« no previous file with comments | « no previous file | src/core/SkColorSpacePriv.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698