Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2171543004: [turbolizer] Remember the last phase, search query, and pane expansions. (Closed)

Created:
4 years, 5 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@t-p6
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Remember the last phase, search query, and pane expansions. BUG= R=danno Committed: https://crrev.com/fbccad5c66701ff8071d0b1c4178f2467d0dc49b Cr-Commit-Position: refs/heads/master@{#38045}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bug in remembering pane state. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M tools/turbolizer/graph-view.js View 1 chunk +4 lines, -1 line 0 comments Download
M tools/turbolizer/turbo-visualizer.js View 1 4 chunks +32 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
bgeron
Please take a look. I'm OOO on Friday, so discussing would best work on a ...
4 years, 5 months ago (2016-07-21 18:18:24 UTC) #1
danno
https://codereview.chromium.org/2171543004/diff/1/tools/turbolizer/turbo-visualizer.js File tools/turbolizer/turbo-visualizer.js (right): https://codereview.chromium.org/2171543004/diff/1/tools/turbolizer/turbo-visualizer.js#newcode237 tools/turbolizer/turbo-visualizer.js:237: setSourceExpanded(getLastExpandedState("source"), true); Here and below, why still pass the ...
4 years, 5 months ago (2016-07-25 14:00:49 UTC) #2
bgeron
Fixed bug! https://codereview.chromium.org/2171543004/diff/1/tools/turbolizer/turbo-visualizer.js File tools/turbolizer/turbo-visualizer.js (right): https://codereview.chromium.org/2171543004/diff/1/tools/turbolizer/turbo-visualizer.js#newcode237 tools/turbolizer/turbo-visualizer.js:237: setSourceExpanded(getLastExpandedState("source"), true); On 2016/07/25 14:00:49, danno wrote: ...
4 years, 5 months ago (2016-07-25 17:29:50 UTC) #3
danno
lgtm
4 years, 4 months ago (2016-07-26 05:53:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171543004/20001
4 years, 4 months ago (2016-07-26 11:10:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 11:44:14 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 11:47:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbccad5c66701ff8071d0b1c4178f2467d0dc49b
Cr-Commit-Position: refs/heads/master@{#38045}

Powered by Google App Engine
This is Rietveld 408576698