Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2169043002: [turbolizer] Factor out some user actions into methods of GraphView. (Closed)

Created:
4 years, 5 months ago by bgeron
Modified:
4 years, 5 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@t-p6-base
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Factor out some user actions into methods of GraphView. BUG= R=danno Committed: https://crrev.com/69c291dc47a4be98587640e533dcaa5e7746cd86 Cr-Commit-Position: refs/heads/master@{#38025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -76 lines) Patch
M tools/turbolizer/graph-view.js View 2 chunks +85 lines, -76 lines 0 comments Download
M tools/turbolizer/util.js View 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
bgeron
Please take a look. I'm OOO on Friday, so discussing would best work on a ...
4 years, 5 months ago (2016-07-21 18:17:30 UTC) #1
danno
lgtm
4 years, 5 months ago (2016-07-25 13:57:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169043002/1
4 years, 5 months ago (2016-07-25 13:59:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 14:23:48 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 14:25:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69c291dc47a4be98587640e533dcaa5e7746cd86
Cr-Commit-Position: refs/heads/master@{#38025}

Powered by Google App Engine
This is Rietveld 408576698