Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2171543002: Split DEPTH_STENCIL into DEPTH and STENCIL in command buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 03ce04134dc62c31df4633c1137cbb290af7591c..fb9377f56e24ba9c6cc3e34eb6050ae018663179 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -7002,7 +7002,12 @@ void GLES2DecoderImpl::DoFramebufferRenderbuffer(
}
GLenum error = LOCAL_PEEK_GL_ERROR("glFramebufferRenderbuffer");
if (error == GL_NO_ERROR) {
- framebuffer->AttachRenderbuffer(attachment, renderbuffer);
+ if (attachment == GL_DEPTH_STENCIL_ATTACHMENT) {
Zhenyao Mo 2016/07/20 20:28:10 You will need to do the same in DoFramebufferTextu
+ framebuffer->AttachRenderbuffer(GL_DEPTH_ATTACHMENT, renderbuffer);
+ framebuffer->AttachRenderbuffer(GL_STENCIL_ATTACHMENT, renderbuffer);
+ } else {
+ framebuffer->AttachRenderbuffer(attachment, renderbuffer);
+ }
}
if (framebuffer == framebuffer_state_.bound_draw_framebuffer.get()) {
framebuffer_state_.clear_state_dirty = true;

Powered by Google App Engine
This is Rietveld 408576698