Rename WebTestProxy to WebViewTestProxy.

Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347
Committed: https://crrev.com/05e4137fc06ab5b10b30ecd053f49190cfbf3b5d
Cr-Commit-Position: refs/heads/master@{#407165}

[lfg, 2016-07-21 17:41:37]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2016-07-21 17:58:58]

Description was changed from

==========
Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it is only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347
==========

to

==========
Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347
==========

[lfg, 2016-07-21 18:44:51]

lfg@chromium.org changed reviewers:
+ lukasza@chromium.org

[lfg, 2016-07-21 18:44:52]

Please take a look.

[commit-bot: I haz the power, 2016-07-21 18:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:59:36]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-07-21 19:14:50]

LGTM with some small nits

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
File components/test_runner/web_frame_test_proxy.h (right):

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
components/test_runner/web_frame_test_proxy.h:48: // WebViewTestProxy is used
during LayoutTests and always instantiated, at time
This probably should be changed to WebFrameTestProxy (I probably introduced this
copy&paste comment error in one of my earlier CLs :-).

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
File components/test_runner/web_view_test_proxy.h (right):

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
components/test_runner/web_view_test_proxy.h:57: // behavior. See
WebViewTestProxy class comments for more information.
This comment is not accurate (after my earlier CLs).  OTOH, I can't think of a
quick way to fix it, so probably not worth blocking this CL on the comment (+ as
I said the inaccuracy comes from my earlier CLs :-( ).

https://codereview.chromium.org/2171503005/diff/1/content/public/test/layoutt...
File content/public/test/layouttest_support.h (right):

https://codereview.chromium.org/2171503005/diff/1/content/public/test/layoutt...
content/public/test/layouttest_support.h:76: void
EnableWebViewTestProxyCreation(
Not sure if "View" is necessary above (as this function handles injecting test
proxies both for "View" and for "Frame" objects [and probably will separately
handle widgets in the future?]).

[lfg, 2016-07-22 04:24:50]

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
File components/test_runner/web_frame_test_proxy.h (right):

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
components/test_runner/web_frame_test_proxy.h:48: // WebViewTestProxy is used
during LayoutTests and always instantiated, at time
On 2016/07/21 19:14:50, Łukasz Anforowicz wrote:
> This probably should be changed to WebFrameTestProxy (I probably introduced
this
> copy&paste comment error in one of my earlier CLs :-).

Done.

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
File components/test_runner/web_view_test_proxy.h (right):

https://codereview.chromium.org/2171503005/diff/1/components/test_runner/web_...
components/test_runner/web_view_test_proxy.h:57: // behavior. See
WebViewTestProxy class comments for more information.
On 2016/07/21 19:14:50, Łukasz Anforowicz wrote:
> This comment is not accurate (after my earlier CLs).  OTOH, I can't think of a
> quick way to fix it, so probably not worth blocking this CL on the comment (+
as
> I said the inaccuracy comes from my earlier CLs :-( ).

I see. Let's revisit this when I get WebWidgetTestProxy working. A lot of the
stuff happening in WebViewTestProxy is just to work around the diamond
inheritance of RenderView, so we should be able to simplify it a lot by having
two separate classes.

https://codereview.chromium.org/2171503005/diff/1/content/public/test/layoutt...
File content/public/test/layouttest_support.h (right):

https://codereview.chromium.org/2171503005/diff/1/content/public/test/layoutt...
content/public/test/layouttest_support.h:76: void
EnableWebViewTestProxyCreation(
On 2016/07/21 19:14:50, Łukasz Anforowicz wrote:
> Not sure if "View" is necessary above (as this function handles injecting test
> proxies both for "View" and for "Frame" objects [and probably will separately
> handle widgets in the future?]).

Done.

[lfg, 2016-07-22 04:25:42]

lfg@chromium.org changed reviewers:
+ jochen@chromium.org

[lfg, 2016-07-22 04:25:43]

+jochen: Please take a look.

[jochen (gone - plz use gerrit), 2016-07-22 12:24:36]

lgtm

[lfg, 2016-07-22 12:31:51]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 12:32:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2016-07-22 13:49:48]

The CQ bit was unchecked by lfg@chromium.org

[lfg, 2016-07-22 13:49:49]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-07-22 13:49:49]

The patchset sent to the CQ was uploaded after l-g-t-m from lukasza@chromium.org
Link to the patchset: https://codereview.chromium.org/2171503005/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2016-07-22 13:50:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 15:38:25]

Description was changed from

==========
Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347
==========

to

==========
Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347
==========

[commit-bot: I haz the power, 2016-07-22 15:38:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 15:39:54]

Description was changed from

==========
Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347
==========

to

==========
Rename WebTestProxy to WebViewTestProxy.

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347

Committed: https://crrev.com/05e4137fc06ab5b10b30ecd053f49190cfbf3b5d
Cr-Commit-Position: refs/heads/master@{#407165}
==========

[commit-bot: I haz the power, 2016-07-22 15:39:56]

Patchset 2 (id:??) landed as
https://crrev.com/05e4137fc06ab5b10b30ecd053f49190cfbf3b5d
Cr-Commit-Position: refs/heads/master@{#407165}