Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2171503005: Rename WebTestProxy to WebViewTestProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/layouttest_support.cc ('k') | tools/valgrind/drmemory/suppressions_full.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 } 114 }
115 115
116 void invalidateRect(const IntRect& paintRect) override 116 void invalidateRect(const IntRect& paintRect) override
117 { 117 {
118 if (!paintRect.isEmpty()) 118 if (!paintRect.isEmpty())
119 m_popup->widgetClient()->didInvalidateRect(paintRect); 119 m_popup->widgetClient()->didInvalidateRect(paintRect);
120 } 120 }
121 121
122 void scheduleAnimation(Widget*) override 122 void scheduleAnimation(Widget*) override
123 { 123 {
124 // Calling scheduleAnimation on m_webView so WebTestProxy will call begi nFrame. 124 // Calling scheduleAnimation on m_webView so WebViewTestProxy will call beginFrame.
125 if (LayoutTestSupport::isRunningLayoutTest()) 125 if (LayoutTestSupport::isRunningLayoutTest())
126 m_popup->m_webView->mainFrameImpl()->frameWidget()->scheduleAnimatio n(); 126 m_popup->m_webView->mainFrameImpl()->frameWidget()->scheduleAnimatio n();
127 127
128 if (m_popup->isAcceleratedCompositingActive()) { 128 if (m_popup->isAcceleratedCompositingActive()) {
129 DCHECK(m_popup->m_layerTreeView); 129 DCHECK(m_popup->m_layerTreeView);
130 m_popup->m_layerTreeView->setNeedsBeginFrame(); 130 m_popup->m_layerTreeView->setNeedsBeginFrame();
131 return; 131 return;
132 } 132 }
133 m_popup->m_widgetClient->scheduleAnimation(); 133 m_popup->m_widgetClient->scheduleAnimation();
134 } 134 }
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 // A WebPagePopupImpl instance usually has two references. 582 // A WebPagePopupImpl instance usually has two references.
583 // - One owned by the instance itself. It represents the visible widget. 583 // - One owned by the instance itself. It represents the visible widget.
584 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 584 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
585 // WebPagePopupImpl to close. 585 // WebPagePopupImpl to close.
586 // We need them because the closing operation is asynchronous and the widget 586 // We need them because the closing operation is asynchronous and the widget
587 // can be closed while the WebViewImpl is unaware of it. 587 // can be closed while the WebViewImpl is unaware of it.
588 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 588 return adoptRef(new WebPagePopupImpl(client)).leakRef();
589 } 589 }
590 590
591 } // namespace blink 591 } // namespace blink
OLDNEW
« no previous file with comments | « content/test/layouttest_support.cc ('k') | tools/valgrind/drmemory/suppressions_full.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698