third_party/WebKit/Source/core/editing/EditingStyle.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/editing/EditingStrategy.cpp ('k') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingStyle.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.cpp b/third_party/WebKit/Source/core/editing/EditingStyle.cpp

index 184dd8401ec2acd85ae9b19c665a41137f2aaebb..163cbfb17e46d3197edc3447aae00c755f919209 100644

--- a/third_party/WebKit/Source/core/editing/EditingStyle.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingStyle.cpp

@@ -747,7 +747,7 @@ TriState EditingStyle::triStateOfStyle(const VisibleSelection& selection) const

TriState state = FalseTriState;

bool nodeIsStart = true;

for (Node& node : NodeTraversal::startsAt(*selection.start().anchorNode())) {

- if (node.layoutObject() && node.hasEditableStyle()) {

+ if (node.layoutObject() && hasEditableStyle(node)) {

CSSComputedStyleDeclaration* nodeStyle = CSSComputedStyleDeclaration::create(&node);

if (nodeStyle) {

// If the selected element has <sub> or <sup> ancestor element, apply the corresponding