third_party/WebKit/Source/core/editing/EditingStrategy.cpp - Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStrategy.cpp

Issue 2171493003: [Editing][DOM][CodeHealth] Make Node::hasEditableStyle global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingStrategy.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

index 181778c3f3c9f4979dda616202fe8d51ddc8a6e6..b85e35c2bfbc522f3b53d60f8733fcba6b115bac 100644

--- a/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingStrategy.cpp

@@ -33,7 +33,7 @@ bool EditingAlgorithm<Traversal>::isEmptyNonEditableNodeInEditable(const Node* n

// Flat Tree:

// <host><div ce><span1>unedittable</span></div></host>

// e.g. editing/shadow/breaking-editing-boundaries.html

- return !Traversal::hasChildren(*node) && !node->hasEditableStyle() && node->parentNode() && node->parentNode()->hasEditableStyle();

+ return !Traversal::hasChildren(*node) && !hasEditableStyle(*node) && node->parentNode() && hasEditableStyle(*node->parentNode());

}

template <typename Traversal>