Handle owner state change in HTMLLinkElement::setCSSStyleSheet

Handle owner state change in HTMLLinkElement::setCSSStyleSheet

imported/web-platform-tests/shadow-dom/shadow-trees/upper-bounary-encapsulation/test-011.html
caused a flaky crashes on trybots.

When an link element started fetching CSS resource the resource loading happens asynchronously in the background, and
when it completes, owner element's state may have changed.

In the test, the owner element moved under shadow tree,
then asserting condition
ASSERT(!linkStyle() || !linkStyle()->hasSheet()).
happened.

BUG=503445
TEST=imported/web-platform-tests/shadow-dom/shadow-trees/upper-boundary-encapusulation/test-011.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201752

[kochi, 2015-08-13 08:13:08]

kochi@chromium.org changed reviewers:
+ tkent@chromium.org

[kochi, 2015-08-13 08:13:08]

PTAL

The flaky crash consistently reproduces on my machine with

blink/tools/run_layout_tests.sh --repeat=20 --debug
imported/web-platform-tests/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-011.html

But this fixes the flaky crash.

[tkent, 2015-08-13 23:41:10]

According to https://code.google.com/p/chromium/issues/detail?id=503445#c11, we
don't find the root cause yet.  We should find it, then fix it though the fix
might be identical to Patch Set 1.

[kochi, 2015-08-14 09:15:04]

agreed.

[kochi, 2015-09-03 05:10:14]

Patchset #2 (id:20001) has been deleted

[kochi, 2015-09-03 05:47:53]

PTAL

[kochi, 2015-09-03 05:47:59]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 05:48:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285413002/60001

[tkent, 2015-09-03 05:53:17]

lgtm

[kochi, 2015-09-03 06:24:44]

The CQ bit was unchecked by kochi@chromium.org

[kochi, 2015-09-03 06:25:00]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2015-09-03 06:25:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285413002/60001

[commit-bot: I haz the power, 2015-09-03 06:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 06:45:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kochi, 2015-09-03 07:02:42]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 07:02:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285413002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285413002/80001

[commit-bot: I haz the power, 2015-09-03 08:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 08:08:06]

Dry run: This issue passed the CQ dry run.

[kochi, 2015-09-03 11:22:35]

It seems patchset3 regressed on some tests.

If CSS resource request ends up in any error condition,
the error has to be propagated to onerror handler etc.
Short-circuiting error condition caused the error not to propagate
properly.

In patchset4, I changed the code to return only when its owner node
moved under shadow root.

This CL looks good for other flaky tests (issue 521960).

[kochi, 2015-09-03 23:01:22]

On 2015/09/03 11:22:35, Takayoshi Kochi wrote:
> It seems patchset3 regressed on some tests.
> 
> If CSS resource request ends up in any error condition,
> the error has to be propagated to onerror handler etc.
> Short-circuiting error condition caused the error not to propagate
> properly.
> 
> In patchset4, I changed the code to return only when its owner node
> moved under shadow root.
> 
> This CL looks good for other flaky tests (issue 521960).

Updated the description.
Could you take another look?

[tkent, 2015-09-03 23:33:35]

lgtm

[kochi, 2015-09-04 00:31:41]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2015-09-04 00:31:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1285413002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1285413002/80001

[commit-bot: I haz the power, 2015-09-04 00:36:39]

Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201752