Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2171213002: Merge: ARC Opt in notification not shown. (Closed)

Created:
4 years, 5 months ago by mtomasz
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge: ARC Opt in notification not shown. As the profile id is not set, the notifications are never shown to user. Instead they land in the notification center, and user needs to click on the "1" icon to see it. This CL fixes the issue by setting a correct profile id on the notification. TEST=Tested manually on a fresh profile. BUG=629399 Review-Url: https://codereview.chromium.org/2160723004 Cr-Commit-Position: refs/heads/master@{#406428} (cherry picked from commit 3ae0dad4690b7579921cd503e6a863467ef27bfe) Committed: https://chromium.googlesource.com/chromium/src/+/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_notification.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_notification.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
mtomasz
4 years, 5 months ago (2016-07-22 07:36:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03b78159f8ddcaca8fb576d8cb3111a7b18df2cf.

Powered by Google App Engine
This is Rietveld 408576698