Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2160723004: ARC Opt in notification not shown. (Closed)

Created:
4 years, 5 months ago by mtomasz
Modified:
4 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARC Opt in notification not shown. As the profile id is not set, the notifications are never shown to user. Instead they land in the notification center, and user needs to click on the "1" icon to see it. This CL fixes the issue by setting a correct profile id on the notification. TEST=Tested manually on a fresh profile. BUG=629399 Committed: https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe Cr-Commit-Position: refs/heads/master@{#406428}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_notification.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_notification.cc View 2 chunks +6 lines, -1 line 2 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
mtomasz
@oshima: PTAL. Thanks!
4 years, 5 months ago (2016-07-19 02:31:52 UTC) #4
oshima
lgtm https://codereview.chromium.org/2160723004/diff/1/chrome/browser/chromeos/arc/arc_auth_notification.cc File chrome/browser/chromeos/arc/arc_auth_notification.cc (right): https://codereview.chromium.org/2160723004/diff/1/chrome/browser/chromeos/arc/arc_auth_notification.cc#newcode12 chrome/browser/chromeos/arc/arc_auth_notification.cc:12: #include "chrome/browser/profiles/profile.h" I believe you don't need this.
4 years, 5 months ago (2016-07-19 15:58:55 UTC) #8
mtomasz
https://codereview.chromium.org/2160723004/diff/1/chrome/browser/chromeos/arc/arc_auth_notification.cc File chrome/browser/chromeos/arc/arc_auth_notification.cc (right): https://codereview.chromium.org/2160723004/diff/1/chrome/browser/chromeos/arc/arc_auth_notification.cc#newcode12 chrome/browser/chromeos/arc/arc_auth_notification.cc:12: #include "chrome/browser/profiles/profile.h" On 2016/07/19 15:58:55, oshima wrote: > I ...
4 years, 5 months ago (2016-07-20 00:22:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160723004/1
4 years, 5 months ago (2016-07-20 00:23:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 00:29:27 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 00:31:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe
Cr-Commit-Position: refs/heads/master@{#406428}

Powered by Google App Engine
This is Rietveld 408576698