Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 2171143002: cc: Get rid of non-delegated rendering in most cc unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@killdirecttests
Patch Set: fakeoutputsurface: cc-blink-tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 17d1bfbafa2afbd0b5bad583148fc1ff8c755f6f..db3fcbd22bf9fcc6177fbf390debd84cbcde091b 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -573,8 +573,7 @@ TEST_F(LayerTreeHostImplTest, NotifyIfCanDrawChanged) {
TEST_F(LayerTreeHostImplTest, ResourcelessDrawWithEmptyViewport) {
CreateHostImpl(DefaultSettings(),
- FakeOutputSurface::CreateDelegatingSoftware(
- base::WrapUnique(new SoftwareOutputDevice())));
+ FakeOutputSurface::CreateDelegatingSoftware());
SetupScrollAndContentsLayers(gfx::Size(100, 100));
host_impl_->active_tree()->BuildPropertyTreesForTesting();
@@ -3800,8 +3799,7 @@ TEST_F(LayerTreeHostImplTest, PrepareToDrawSucceedsAndFails) {
TEST_F(LayerTreeHostImplTest,
PrepareToDrawWhenDrawAndSwapFullViewportEveryFrame) {
CreateHostImpl(DefaultSettings(),
- FakeOutputSurface::CreateDelegatingSoftware(
- base::WrapUnique(new SoftwareOutputDevice())));
+ FakeOutputSurface::CreateDelegatingSoftware());
const gfx::Transform external_transform;
const gfx::Rect external_viewport;
@@ -6759,10 +6757,8 @@ class LayerTreeHostImplViewportCoveredTest : public LayerTreeHostImplTest {
did_activate_pending_tree_(false) {}
std::unique_ptr<OutputSurface> CreateFakeOutputSurface(bool software) {
- if (software) {
- return FakeOutputSurface::CreateDelegatingSoftware(
- base::WrapUnique(new SoftwareOutputDevice()));
- }
+ if (software)
+ return FakeOutputSurface::CreateDelegatingSoftware();
return FakeOutputSurface::CreateDelegating3d();
}
@@ -7643,9 +7639,8 @@ class CountingSoftwareDevice : public SoftwareOutputDevice {
TEST_F(LayerTreeHostImplTest,
ForcedDrawToSoftwareDeviceSkipsUnsupportedLayers) {
set_reduce_memory_result(false);
- EXPECT_TRUE(CreateHostImpl(
- DefaultSettings(), FakeOutputSurface::CreateDelegatingSoftware(
- base::WrapUnique(new CountingSoftwareDevice))));
+ EXPECT_TRUE(CreateHostImpl(DefaultSettings(),
+ FakeOutputSurface::CreateDelegatingSoftware()));
const gfx::Transform external_transform;
const gfx::Rect external_viewport;
@@ -10857,8 +10852,7 @@ TEST_F(LayerTreeHostImplTest, RecomputeGpuRasterOnOutputSurfaceChange) {
EXPECT_TRUE(host_impl_->use_gpu_rasterization());
// Re-initialize with a software output surface.
- output_surface_ = FakeOutputSurface::CreateDelegatingSoftware(
- base::WrapUnique(new SoftwareOutputDevice));
+ output_surface_ = FakeOutputSurface::CreateDelegatingSoftware();
host_impl_->InitializeRenderer(output_surface_.get());
EXPECT_FALSE(host_impl_->use_gpu_rasterization());
}

Powered by Google App Engine
This is Rietveld 408576698