Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: cc/layers/layer_unittest.cc

Issue 2171143002: cc: Get rid of non-delegated rendering in most cc unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@killdirecttests
Patch Set: fakeoutputsurface: cc-blink-tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_unittest.cc
diff --git a/cc/layers/layer_unittest.cc b/cc/layers/layer_unittest.cc
index 179e0a50eff8e70f516d90a8e95b500a330eb2f7..931232a6ef0096b4a38b3f5d8e7b74410f5ea1c4 100644
--- a/cc/layers/layer_unittest.cc
+++ b/cc/layers/layer_unittest.cc
@@ -109,7 +109,7 @@ namespace cc {
// have a wrapper method in this class called RunFooBarTest.
class LayerSerializationTest : public testing::Test {
public:
- LayerSerializationTest() : fake_client_(FakeLayerTreeHostClient::DIRECT_3D) {}
+ LayerSerializationTest() = default;
vmpstr 2016/07/22 20:24:36 Do we need an explicit ctor here?
danakj 2016/07/22 20:34:57 Probly not! I don't see any non-default assignment
protected:
void SetUp() override {
@@ -899,8 +899,7 @@ class LayerTest : public testing::Test {
: host_impl_(LayerTreeSettings(),
&task_runner_provider_,
&shared_bitmap_manager_,
- &task_graph_runner_),
- fake_client_(FakeLayerTreeHostClient::DIRECT_3D) {
+ &task_graph_runner_) {
timeline_impl_ =
AnimationTimeline::Create(AnimationIdProvider::NextTimelineId());
timeline_impl_->set_is_impl_only(true);
@@ -1846,8 +1845,6 @@ TEST_F(LayerTest, MaskAndReplicaHasParent) {
class LayerTreeHostFactory {
public:
- LayerTreeHostFactory() : client_(FakeLayerTreeHostClient::DIRECT_3D) {}
-
std::unique_ptr<LayerTreeHost> Create() {
return Create(LayerTreeSettings());
}

Powered by Google App Engine
This is Rietveld 408576698