Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 217103004: Ignore MediaController in the muted/volume controls logic (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: repaint in updateVolume Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/media-volume-slider-hit-test-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 63f3ab8d68cf58ef98b73aa039900d32aa741496..da104907380d1c2633e513799570af261fedd608 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -85,7 +85,7 @@ public:
blink::WebMediaPlayer* webMediaPlayer() const { return m_player ? m_player->webMediaPlayer() : 0; }
virtual bool hasVideo() const { return false; }
- virtual bool hasAudio() const OVERRIDE FINAL;
+ bool hasAudio() const;
bool supportsSave() const;
@@ -152,10 +152,10 @@ public:
// controls
bool controls() const;
void setControls(bool);
- virtual double volume() const OVERRIDE FINAL;
- virtual void setVolume(double, ExceptionState&) OVERRIDE FINAL;
- virtual bool muted() const OVERRIDE FINAL;
- virtual void setMuted(bool) OVERRIDE FINAL;
+ double volume() const;
+ void setVolume(double, ExceptionState&);
+ bool muted() const;
+ void setMuted(bool);
// play/pause toggling that uses the media controller if present. togglePlayStateWillPlay() is
// true if togglePlayState() will call play() or unpause() on the media element or controller.
« no previous file with comments | « LayoutTests/media/media-volume-slider-hit-test-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698