Source/core/html/HTMLMediaElement.cpp - Issue 217103004: Ignore MediaController in the muted/volume controls logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 217103004: Ignore MediaController in the muted/volume controls logic (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: repaint in updateVolume Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index ac494fce3d1992cf69dfa837c068cdd150e03ad4..e1d893b8f8c686596a7d8302bfef9a3c404c3509 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -2117,9 +2117,6 @@ void HTMLMediaElement::setMuted(bool muted)

updateVolume();

- if (hasMediaControls())

- mediaControls()->changedMute();

scheduleEvent(EventTypeNames::volumechange);

}

@@ -2972,7 +2969,7 @@ void HTMLMediaElement::updateVolume()

webMediaPlayer()->setVolume(playerVolume());

if (hasMediaControls())

- mediaControls()->changedVolume();

+ mediaControls()->updateVolume();

}

double HTMLMediaElement::playerVolume() const

« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/html/MediaController.h » ('j') | no next file with comments »