Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2170783003: Adding _getBoolAttribute helper method (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/observatory/lib/src/elements/nav/menu_wrapper.dart View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-21 18:24:15 UTC) #2
Cutch
https://codereview.chromium.org/2170783003/diff/1/runtime/observatory/lib/src/elements/nav/menu_wrapper.dart File runtime/observatory/lib/src/elements/nav/menu_wrapper.dart (right): https://codereview.chromium.org/2170783003/diff/1/runtime/observatory/lib/src/elements/nav/menu_wrapper.dart#newcode40 runtime/observatory/lib/src/elements/nav/menu_wrapper.dart:40: _last = _getBoolAttribute('last'); Aren't there multiple places that this ...
4 years, 5 months ago (2016-07-21 18:25:03 UTC) #3
cbernaschina
4 years, 5 months ago (2016-07-21 18:28:22 UTC) #4
cbernaschina
https://codereview.chromium.org/2170783003/diff/1/runtime/observatory/lib/src/elements/nav/menu_wrapper.dart File runtime/observatory/lib/src/elements/nav/menu_wrapper.dart (right): https://codereview.chromium.org/2170783003/diff/1/runtime/observatory/lib/src/elements/nav/menu_wrapper.dart#newcode40 runtime/observatory/lib/src/elements/nav/menu_wrapper.dart:40: _last = _getBoolAttribute('last'); On 2016/07/21 18:25:03, Cutch wrote: > ...
4 years, 5 months ago (2016-07-21 22:03:03 UTC) #5
Cutch
lgtm
4 years, 5 months ago (2016-07-21 22:05:09 UTC) #6
cbernaschina
4 years, 5 months ago (2016-07-21 23:14:37 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fd1a5298250649d573d09e6424bb5bcacdd1ff81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698