Adding _getBoolAttribute helper method

runtime/observatory/lib/src/elements/nav/menu_wrapper.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:html';
 
 import 'package:observatory/app.dart';
 import 'package:observatory/src/elements/helpers/tag.dart';
 import 'package:observatory/src/elements/shims/binding.dart';
 import 'package:observatory/src/elements/nav/menu.dart';
@@ skipping 19 matching lines @@
     _link = value; render();
   }
   set last(bool value) {
     _last = value; render();
   }
 
   NavMenuElementWrapper.created() : super.created() {
     binder.registerCallback(this);
     _anchor = getAttribute('anchor');
     _link = getAttribute('link');
-    _last = getAttribute('') != null;
+    _last = _getBoolAttribute('last');

[Cutch, 2016/07/21 18:25:03]

Aren't there multiple places that this should be used?

[cbernaschina, 2016/07/21 22:03:03]

all the ...-nav-menu
I've already updated the relative CLs

     createShadowRoot();
     render();
   }
 
   @override
   void attached() {
     super.attached();
     render();
   }
 
   void render() {
     shadowRoot.children = [];
     if (_anchor == null || _last == null) return;
 
     shadowRoot.children = [
       new NavMenuElement(_anchor, link: _link, last: last,
                                  queue: ObservatoryApplication.app.queue)
         ..children = [new ContentElement()]
     ];
   }
+
+  bool _getBoolAttribute(String name) {
+    final String value = getAttribute('last');
+    return !(value == null || value == 'false');
+  }
 }