Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h

Issue 2170783002: Add a timeout to the update event in case page doesn't resolve promise from updateWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed the DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h
index 510c707dbf2fc8e33df6f30299c5d7c57ed60219..87141d1f96e498c01bd522fce3540742e6788929 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h
@@ -10,6 +10,7 @@
#include "core/events/Event.h"
#include "modules/ModulesExport.h"
#include "modules/payments/PaymentRequestUpdateEventInit.h"
+#include "platform/Timer.h"
#include "platform/heap/Handle.h"
namespace blink {
@@ -31,6 +32,8 @@ public:
void updateWith(ScriptState*, ScriptPromise, ExceptionState&);
+ void onTimerFired(Timer<PaymentRequestUpdateEvent>*);
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -39,6 +42,7 @@ private:
Member<PaymentUpdater> m_updater;
bool m_waitForUpdate;
+ Timer<PaymentRequestUpdateEvent> m_abortTimer;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698