Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h

Issue 2170783002: Add a timeout to the update event in case page doesn't resolve promise from updateWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed the DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PaymentRequestUpdateEvent_h 5 #ifndef PaymentRequestUpdateEvent_h
6 #define PaymentRequestUpdateEvent_h 6 #define PaymentRequestUpdateEvent_h
7 7
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "bindings/core/v8/ScriptWrappable.h" 9 #include "bindings/core/v8/ScriptWrappable.h"
10 #include "core/events/Event.h" 10 #include "core/events/Event.h"
11 #include "modules/ModulesExport.h" 11 #include "modules/ModulesExport.h"
12 #include "modules/payments/PaymentRequestUpdateEventInit.h" 12 #include "modules/payments/PaymentRequestUpdateEventInit.h"
13 #include "platform/Timer.h"
13 #include "platform/heap/Handle.h" 14 #include "platform/heap/Handle.h"
14 15
15 namespace blink { 16 namespace blink {
16 17
17 class ExceptionState; 18 class ExceptionState;
18 class PaymentUpdater; 19 class PaymentUpdater;
19 class ScriptState; 20 class ScriptState;
20 21
21 class MODULES_EXPORT PaymentRequestUpdateEvent final : public Event { 22 class MODULES_EXPORT PaymentRequestUpdateEvent final : public Event {
22 DEFINE_WRAPPERTYPEINFO(); 23 DEFINE_WRAPPERTYPEINFO();
23 24
24 public: 25 public:
25 ~PaymentRequestUpdateEvent() override; 26 ~PaymentRequestUpdateEvent() override;
26 27
27 static PaymentRequestUpdateEvent* create(); 28 static PaymentRequestUpdateEvent* create();
28 static PaymentRequestUpdateEvent* create(const AtomicString& type, const Pay mentRequestUpdateEventInit& = PaymentRequestUpdateEventInit()); 29 static PaymentRequestUpdateEvent* create(const AtomicString& type, const Pay mentRequestUpdateEventInit& = PaymentRequestUpdateEventInit());
29 30
30 void setPaymentDetailsUpdater(PaymentUpdater*); 31 void setPaymentDetailsUpdater(PaymentUpdater*);
31 32
32 void updateWith(ScriptState*, ScriptPromise, ExceptionState&); 33 void updateWith(ScriptState*, ScriptPromise, ExceptionState&);
33 34
35 void onTimerFired(Timer<PaymentRequestUpdateEvent>*);
36
34 DECLARE_VIRTUAL_TRACE(); 37 DECLARE_VIRTUAL_TRACE();
35 38
36 private: 39 private:
37 PaymentRequestUpdateEvent(); 40 PaymentRequestUpdateEvent();
38 PaymentRequestUpdateEvent(const AtomicString& type, const PaymentRequestUpda teEventInit&); 41 PaymentRequestUpdateEvent(const AtomicString& type, const PaymentRequestUpda teEventInit&);
39 42
40 Member<PaymentUpdater> m_updater; 43 Member<PaymentUpdater> m_updater;
41 bool m_waitForUpdate; 44 bool m_waitForUpdate;
45 Timer<PaymentRequestUpdateEvent> m_abortTimer;
42 }; 46 };
43 47
44 } // namespace blink 48 } // namespace blink
45 49
46 #endif // PaymentRequestUpdateEvent_h 50 #endif // PaymentRequestUpdateEvent_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698