Moves AcceleratorController from Shell to WmShell

Moves AcceleratorController from Shell to WmShell

BUG=612331
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0
Cr-Commit-Position: refs/heads/master@{#407024}

[sky, 2016-07-21 19:12:28]

https://codereview.chromium.org/2170753005/diff/20001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_delegate_mus.h (right):

https://codereview.chromium.org/2170753005/diff/20001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_delegate_mus.h:16: class
AcceleratorControllerDelegateMus : public AcceleratorControllerDelegate {
I'll add a better description of this class when it actually does something.

[sky, 2016-07-21 19:12:32]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:35:31]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-07-21 21:20:49]

LGTM with question

https://codereview.chromium.org/2170753005/diff/20001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_delegate_mus.h (right):

https://codereview.chromium.org/2170753005/diff/20001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_delegate_mus.h:16: class
AcceleratorControllerDelegateMus : public AcceleratorControllerDelegate {
On 2016/07/21 19:12:28, sky wrote:
> I'll add a better description of this class when it actually does something.

Acknowledged.

https://codereview.chromium.org/2170753005/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2170753005/diff/20001/ash/shell.cc#newcode890
ash/shell.cc:890: }
Q: Why does this need to be in its own scope?

[sky, 2016-07-21 21:31:57]

https://codereview.chromium.org/2170753005/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2170753005/diff/20001/ash/shell.cc#newcode890
ash/shell.cc:890: }
On 2016/07/21 21:20:49, James Cook wrote:
> Q: Why does this need to be in its own scope?

It doesn't. I went with the scoping because of the
std::move(accelerator_controller)) on 889. After that accelerator_controller is
null. Without the scoping it's easy to miss that accelerator_controller is null
after 889. I find scoping like this helps prevent errors.

[James Cook, 2016-07-21 22:06:12]

got it. still lgtm

[sky, 2016-07-21 22:07:46]

On 2016/07/21 21:31:57, sky wrote:
> https://codereview.chromium.org/2170753005/diff/20001/ash/shell.cc
> File ash/shell.cc (right):
> 
> https://codereview.chromium.org/2170753005/diff/20001/ash/shell.cc#newcode890
> ash/shell.cc:890: }
> On 2016/07/21 21:20:49, James Cook wrote:
> > Q: Why does this need to be in its own scope?
> 
> It doesn't. I went with the scoping because of the
> std::move(accelerator_controller)) on 889. After that accelerator_controller
is
> null. Without the scoping it's easy to miss that accelerator_controller is
null
> after 889. I find scoping like this helps prevent errors.

I changed the code to not have a local for AcceleratorController and removed the
scope.

[sky, 2016-07-21 22:08:57]

The CQ bit was checked by sky@chromium.org

[sky, 2016-07-21 22:08:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2170753005/#ps60001
(title: "no scope")

[commit-bot: I haz the power, 2016-07-21 22:09:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 22:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 22:34:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-07-21 22:59:45]

The CQ bit was checked by sky@chromium.org

[sky, 2016-07-21 22:59:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2170753005/#ps80001
(title: "WmShell")

[commit-bot: I haz the power, 2016-07-21 23:00:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 23:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:26:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-07-21 23:31:44]

The CQ bit was checked by sky@chromium.org

[sky, 2016-07-21 23:31:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2170753005/#ps100001
(title: "include")

[commit-bot: I haz the power, 2016-07-21 23:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:28:46]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-22 03:31:34]

Description was changed from

==========
Moves AcceleratorController from Shell to WmShell

BUG=612331
TEST=none
R=jamescook@chromium.org
==========

to

==========
Moves AcceleratorController from Shell to WmShell

BUG=612331
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0
Cr-Commit-Position: refs/heads/master@{#407024}
==========

[commit-bot: I haz the power, 2016-07-22 03:31:36]

Patchset 6 (id:??) landed as
https://crrev.com/89eb8019e501cf7434f275481ddf0ba0f9d618c0
Cr-Commit-Position: refs/heads/master@{#407024}