Move processing out of AcceleratorDelegate

Move processing out of AcceleratorDelegate

AcceleratorDelegate now trivially forwards to AcceleratorRouter, which
is now in terms of ash/common types.

BUG=612331
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56
Cr-Commit-Position: refs/heads/master@{#407198}

[sky, 2016-07-21 23:48:31]

https://codereview.chromium.org/2171983002/diff/20001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2171983002/diff/20001/ash/common/wm_window.h#...
ash/common/wm_window.h:133: virtual WmWindow* GetToplevelWindowForFocus() = 0;
This makes me sad, but I'm rather worried about changing the usage as the two
implementations (for aura) are very different.

[sky, 2016-07-22 16:24:20]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 16:24:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-22 16:48:03]

LGTM with nits.

It makes me sad too, but that's the price we pay when refactoring large piles of
code. :-)

https://codereview.chromium.org/2171983002/diff/40001/ash/accelerators/accele...
File ash/accelerators/accelerator_delegate.h (right):

https://codereview.chromium.org/2171983002/diff/40001/ash/accelerators/accele...
ash/accelerators/accelerator_delegate.h:11: #include "base/compiler_specific.h"
nit: remove while you're here

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
File ash/common/accelerators/accelerator_router.cc (right):

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
ash/common/accelerators/accelerator_router.cc:80: // On ChromeOS, If the
accelerator is Search+<key(s)> then it must never be
optional nit: DCHECK(target) like above?

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
File ash/common/accelerators/accelerator_router.h (right):

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
ash/common/accelerators/accelerator_router.h:40: // event filter.
Is it still true that ash has an env event filter? If that means global, it
isn't true on mus.

[commit-bot: I haz the power, 2016-07-22 17:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:03:09]

Dry run: This issue passed the CQ dry run.

[sky, 2016-07-22 17:05:06]

https://codereview.chromium.org/2171983002/diff/40001/ash/accelerators/accele...
File ash/accelerators/accelerator_delegate.h (right):

https://codereview.chromium.org/2171983002/diff/40001/ash/accelerators/accele...
ash/accelerators/accelerator_delegate.h:11: #include "base/compiler_specific.h"
On 2016/07/22 16:48:02, James Cook wrote:
> nit: remove while you're here

That one is needed because of NON_EXPORTED_BASE.

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
File ash/common/accelerators/accelerator_router.cc (right):

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
ash/common/accelerators/accelerator_router.cc:80: // On ChromeOS, If the
accelerator is Search+<key(s)> then it must never be
On 2016/07/22 16:48:02, James Cook wrote:
> optional nit: DCHECK(target) like above?

Done.

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
File ash/common/accelerators/accelerator_router.h (right):

https://codereview.chromium.org/2171983002/diff/40001/ash/common/accelerators...
ash/common/accelerators/accelerator_router.h:40: // event filter.
On 2016/07/22 16:48:02, James Cook wrote:
> Is it still true that ash has an env event filter? If that means global, it
> isn't true on mus.

Updated comment (removed portion after ',').

[sky, 2016-07-22 17:05:34]

The CQ bit was checked by sky@chromium.org

[sky, 2016-07-22 17:05:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2171983002/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2016-07-22 17:05:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:58:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-22 18:00:40]

Description was changed from

==========
Move processing out of AcceleratorDelegate

AcceleratorDelegate now trivially forwards to AcceleratorRouter, which
is now in terms of ash/common types.

BUG=612331
TEST=none
R=jamescook@chromium.org
==========

to

==========
Move processing out of AcceleratorDelegate

AcceleratorDelegate now trivially forwards to AcceleratorRouter, which
is now in terms of ash/common types.

BUG=612331
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56
Cr-Commit-Position: refs/heads/master@{#407198}
==========

[commit-bot: I haz the power, 2016-07-22 18:00:41]

Patchset 4 (id:??) landed as
https://crrev.com/eed46f8917f47c85ac37c8f04267058905beda56
Cr-Commit-Position: refs/heads/master@{#407198}