Issue 217073004: Reland "Use v8 Microtask Queue"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217073004: Reland "Use v8 Microtask Queue" (Closed)

Created:
6 years, 9 months ago by rafaelw

Modified:
6 years, 8 months ago

Reviewers:
Jeffrey Yasskin, adamk, earthdok

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Original issue: https://codereview.chromium.org/167683003/ This version contains the LSAN suppression discussed on the original issue. Use v8 Microtask Queue V8 now hosts the end-of-microtask work queue. This allows consistent scheduling of microtask work regardless of where it is implemented (v8 vs blink). TBR=adamk,jyasskin,earthdok BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170386

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Patch Set 4 : wee #

Patch Set 5 : add supressions #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -27 lines)			Patch
M	LayoutTests/inspector/sources/debugger/async-callstack-mutation-observer-expected.txt	View	1 2 3 4	6 chunks	+10 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/ScriptRegexp.cpp	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/V8PerIsolateData.h	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/V8PerIsolateData.cpp	View	1 2 3 4	2 chunks	+8 lines, -4 lines	0 comments	Download
M	Source/core/dom/Microtask.cpp	View	1 2 3 4	1 chunk	+26 lines, -17 lines	0 comments	Download
M	Source/web/WebKit.cpp	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/LeakAnnotations.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/217073004/80001

6 years, 9 months ago (2014-03-28 23:04:15 UTC) #2

Message was sent while issue was closed.

Change committed as 170386

Expand Messages | Collapse Messages