Use dom-repeat for addresses, credit cards, and exceptions.

Use dom-repeat for addresses, credit cards, and exceptions.

Dom-repeat doesn't have the same refresh issues as iron-list. The lists
of addresses, saved credit cards, and password exceptions aren't
expected to be too large so there's not a big gain from using iron-list
over dom-repeat for them.

BUG=600812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/81ab2a7d8e8fbd3fb174522f7df331f0077c3b27
Cr-Commit-Position: refs/heads/master@{#407931}

[hcarmona, 2016-07-21 00:56:31]

Description was changed from

==========
Use dom-repeat for addresses, credit cards, and exceptions.

Dom-repeat doesn't have the same refresh issues as iron-list. The lists
of addresses, saved credit cards, and password exceptions aren't
expected to be too large so there's not a big gain from using iron-list
over dom-repeat for them.

BUG=600812
==========

to

==========
Use dom-repeat for addresses, credit cards, and exceptions.

Dom-repeat doesn't have the same refresh issues as iron-list. The lists
of addresses, saved credit cards, and password exceptions aren't
expected to be too large so there's not a big gain from using iron-list
over dom-repeat for them.

BUG=600812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-21 00:56:34]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:56:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-07-21 01:08:48]

hcarmona@chromium.org changed reviewers:
+ michaelpg@chromium.org

[hcarmona, 2016-07-21 01:08:48]

Several stand-ups ago you mentioned switching these lists to dom-repeat
instead of iron-list.

Passwords is still an iron-list as that could get long. I'm going to
back to investigating the possibility of adding a scroll target for
that one to see if that helps.

[commit-bot: I haz the power, 2016-07-21 01:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:19:28]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[michaelpg, 2016-07-21 03:56:13]

lgtm, but, will this slow force-rendering for search? ideally it shouldn't,
since we don't need this data to be populated for search (IIUC).

if search does force-create these pages and that populates the templates, we
should consider using initial-count. i've opened crbug.com/630081 to track the
idea.

https://codereview.chromium.org/2170713002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
(right):

https://codereview.chromium.org/2170713002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/settings_passwords_section_browsertest.js:93:
return Array.prototype.slice.call(element.children, 0, -1);
Comment here what the -1 is for (the <template>)

[hcarmona, 2016-07-22 21:54:57]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 21:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 22:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:41:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hcarmona, 2016-07-26 01:55:20]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 02:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:45:26]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-07-26 18:28:48]

PTAL at the filtering change for password exceptions. Nothing else major
required to fix tests.

https://codereview.chromium.org/2170713002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
(right):

https://codereview.chromium.org/2170713002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/settings_passwords_section_browsertest.js:93:
return Array.prototype.slice.call(element.children, 0, -1);
On 2016/07/21 03:56:13, michaelpg wrote:
> Comment here what the -1 is for (the <template>)

Done.

https://codereview.chromium.org/2170713002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2170713002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:104:
<template is="dom-repeat" items="[[passwordExceptions]]"
dom-repeat does filtering differently. Had to update.

[michaelpg, 2016-07-26 20:28:39]

lgtm

https://codereview.chromium.org/2170713002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
(right):

https://codereview.chromium.org/2170713002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js:122:
return exception.exceptionUrl.includes(filter);
Yikes. Congrats on being our resident expert on filtering now!

https://codereview.chromium.org/2170713002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
(right):

https://codereview.chromium.org/2170713002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_passwords_section_browsertest.js:94:
return Array.prototype.slice.call(element.children, 0, -1);
Do you think we should assert the last element is actually a <template>? (i'm
not saying we necessarily should)

[hcarmona, 2016-07-26 20:55:52]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 20:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 21:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 21:57:18]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-07-26 22:08:15]

Added template check, committing. :-)

https://codereview.chromium.org/2170713002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
(right):

https://codereview.chromium.org/2170713002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_passwords_section_browsertest.js:94:
return Array.prototype.slice.call(element.children, 0, -1);
On 2016/07/26 20:28:39, michaelpg wrote:
> Do you think we should assert the last element is actually a <template>? (i'm
> not saying we necessarily should)

Done.

[hcarmona, 2016-07-26 22:08:23]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-26 22:08:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2170713002/#ps60001
(title: "Verify Template is a Template")

[commit-bot: I haz the power, 2016-07-26 22:08:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:15:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 22:19:26]

Description was changed from

==========
Use dom-repeat for addresses, credit cards, and exceptions.

Dom-repeat doesn't have the same refresh issues as iron-list. The lists
of addresses, saved credit cards, and password exceptions aren't
expected to be too large so there's not a big gain from using iron-list
over dom-repeat for them.

BUG=600812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Use dom-repeat for addresses, credit cards, and exceptions.

Dom-repeat doesn't have the same refresh issues as iron-list. The lists
of addresses, saved credit cards, and password exceptions aren't
expected to be too large so there's not a big gain from using iron-list
over dom-repeat for them.

BUG=600812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/81ab2a7d8e8fbd3fb174522f7df331f0077c3b27
Cr-Commit-Position: refs/heads/master@{#407931}
==========

[commit-bot: I haz the power, 2016-07-26 22:19:27]

Patchset 4 (id:??) landed as
https://crrev.com/81ab2a7d8e8fbd3fb174522f7df331f0077c3b27
Cr-Commit-Position: refs/heads/master@{#407931}