chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js - Issue 2170713002: Use dom-repeat for addresses, credit cards, and exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 2170713002: Use dom-repeat for addresses, credit cards, and exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Verify Template is a Template Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | chrome/test/data/webui/settings/settings_autofill_section_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

index 42344e69b78952d335ef3a24fd5489a97ae1f5c3..9e7018aef08033c3be8016985e868af16a4b9e0d 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

@@ -113,18 +113,14 @@ Polymer({

/**

- * @param {!Array<!chrome.passwordsPrivate.ExceptionPair>} passwordExceptions

* @param {string} filter

- * @return {!Array<!chrome.passwordsPrivate.ExceptionPair>}

+ * @return {function(!chrome.passwordsPrivate.ExceptionPair): boolean}

* @private

- getFilteredExceptions_: function(passwordExceptions, filter) {

- if (!filter)

- return passwordExceptions;

- return passwordExceptions.filter(function(exception) {

+ passwordExceptionFilter_: function(filter) {

+ return function(exception) {

return exception.exceptionUrl.includes(filter);

- });

+ };

/**