Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2170693002:
[Payments] Select and add buttons for incomplete sections (Closed)
Description[Payments] Select and add buttons for incomplete sections
* Replaces the previous "Select shipping address" or "Select shipping option"
prompts with gigantic [SELECT] and [ADD] buttons on the right of each
incomplete section.
* Caches a copy of the SectionInformation in the relevant PaymentRequestSection
instances so that we can determine if we need to prompt the user to SELECT
or ADD new PaymentOptions.
* Buttons are enabled from top to bottom, with only one button enabled at a
time. This encourages users to move downward while filling out the form.
When a button is visible for a section, the only way to interact with the
section is via the button (no more clicking on incomplete sections to expand
them).
* The shipping summary section, which combines both the shipping address and
shipping option fields, can now display a button that shows either the
button for the incomplete shipping address section or the incomplete shipping
option section (prioritized in taht order).
* Get rid of and generalizes a bunch of unneeded strings.
* Because the logic is so complicated now, we consolidate most layout updates
and view visibility checks to updateControlLayout().
* Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the
lack of summary text for incomplete sections.
* Edits the "select shipping address" string to add "and requirements" to the end.
Videos:
https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE
https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8
BUG=603635
Committed: https://crrev.com/cdb475af0865b21209833f6a2f5a6e675efbc845
Cr-Commit-Position: refs/heads/master@{#407289}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Comments #Patch Set 3 : Fix adding behavior #Patch Set 4 : Tracking another branch #
Total comments: 10
Patch Set 5 : Comments, rebasing #Patch Set 6 : Compile fix, string change #Patch Set 7 : Remove polish to make tests happy #Messages
Total messages: 36 (21 generated)
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ==========
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ==========
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ==========
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 ==========
dfalcantara@chromium.org changed reviewers: + ianwen@chromium.org, rouslan@chromium.org
Rouslan: General Payments things, including the test changes. Ian: UI changes (pretty much all of it). https://chromiumcodereview.appspot.com/2170693002/diff/1/chrome/android/java/... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (left): https://chromiumcodereview.appspot.com/2170693002/diff/1/chrome/android/java/... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:179: boolean isExpanded = moved to updateControlLayout()
On 2016/07/21 01:01:55, dfalcantara wrote: > Rouslan: General Payments things, including the test changes. > > Ian: UI changes (pretty much all of it). > > https://chromiumcodereview.appspot.com/2170693002/diff/1/chrome/android/java/... > File > chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java > (left): > > https://chromiumcodereview.appspot.com/2170693002/diff/1/chrome/android/java/... > chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:179: > boolean isExpanded = > moved to updateControlLayout() Er just found a bug with adding new shipping options. Please hold off on the review :/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Fixed the address and fixed the video links. PTAL when you've got a few.
Trying to figure out how to add tests for the new behavior, but haven't come up with anything I'm too happy with, yet.
On 2016/07/21 18:24:59, dfalcantara wrote: > Trying to figure out how to add tests for the new behavior, but haven't come up > with anything I'm too happy with, yet. If you give me some verbal descriptions of the flows that you want tested, I can code some up.
lgtm % comments. Also please make sure that "Shipping option" button cannot be [ADD], because user cannot add a shipping option. (The [ADD] button is visible in "Shipping option" section when changing address on https://rsolomakhin.github.io/pr/us/.) https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java (right): https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:831: org.chromium.base.Log.e("dfalcantara", "Expanding: " + section); Please remove https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java (right): https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:232: protected Integer getSummarySectionButtonState() throws ExecutionException { getNumberOfContactDetailSuggestions() below uses "int" instead. Let's be consistent in this file.
rs lgtm. I only found some optional nit. https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:100: public static final int EDIT_BUTTON_GONE = 0; Correct me if I'm wrong. Should this be EDIT_BUTTON_CHEVRON? https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:103: public static final int EDIT_BUTTON_SELECT = 1; Also, shall we increase the values of these new constants so that they won't mistakenly be confused with DISPLAY_MODE_XXX? https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:131: protected int mDisplayMode; Move this line to #124, above the private stuff?
https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java (right): https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:100: public static final int EDIT_BUTTON_GONE = 0; On 2016/07/22 17:11:00, Ian Wen wrote: > Correct me if I'm wrong. Should this be EDIT_BUTTON_CHEVRON? The edit button and chevron are different controls that are mutually exclusive. https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:103: public static final int EDIT_BUTTON_SELECT = 1; On 2016/07/22 17:11:00, Ian Wen wrote: > Also, shall we increase the values of these new constants so that they won't > mistakenly be confused with DISPLAY_MODE_XXX? Done. https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:131: protected int mDisplayMode; On 2016/07/22 17:11:00, Ian Wen wrote: > Move this line to #124, above the private stuff? Not sure what the correct ordering is here, but I've moved it. https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java (right): https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:831: org.chromium.base.Log.e("dfalcantara", "Expanding: " + section); On 2016/07/21 21:32:25, Rouslan (ツ) wrote: > Please remove Erk, oops. https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java (right): https://chromiumcodereview.appspot.com/2170693002/diff/60001/chrome/android/j... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:232: protected Integer getSummarySectionButtonState() throws ExecutionException { On 2016/07/21 21:32:25, Rouslan (ツ) wrote: > getNumberOfContactDetailSuggestions() below uses "int" instead. Let's be > consistent in this file. Done.
The CQ bit was checked by dfalcantara@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org, rouslan@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/2170693002/#ps80001 (title: "Comments, rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
(Also added a line in the spreadsheet to test this whole thing. Tests seem to be generally marked as P3, though, underneath the polish P2s.)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. * Edits the "select shipping address" string to add "and requirements" to the end. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 ==========
The CQ bit was checked by dfalcantara@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org, rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2170693002/#ps100001 (title: "Compile fix, string change")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dfalcantara@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org, rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2170693002/#ps120001 (title: "Remove polish to make tests happy")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. * Edits the "select shipping address" string to add "and requirements" to the end. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. * Edits the "select shipping address" string to add "and requirements" to the end. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. * Edits the "select shipping address" string to add "and requirements" to the end. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 ========== to ========== [Payments] Select and add buttons for incomplete sections * Replaces the previous "Select shipping address" or "Select shipping option" prompts with gigantic [SELECT] and [ADD] buttons on the right of each incomplete section. * Caches a copy of the SectionInformation in the relevant PaymentRequestSection instances so that we can determine if we need to prompt the user to SELECT or ADD new PaymentOptions. * Buttons are enabled from top to bottom, with only one button enabled at a time. This encourages users to move downward while filling out the form. When a button is visible for a section, the only way to interact with the section is via the button (no more clicking on incomplete sections to expand them). * The shipping summary section, which combines both the shipping address and shipping option fields, can now display a button that shows either the button for the incomplete shipping address section or the incomplete shipping option section (prioritized in taht order). * Get rid of and generalizes a bunch of unneeded strings. * Because the logic is so complicated now, we consolidate most layout updates and view visibility checks to updateControlLayout(). * Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the lack of summary text for incomplete sections. * Edits the "select shipping address" string to add "and requirements" to the end. Videos: https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8 BUG=603635 Committed: https://crrev.com/cdb475af0865b21209833f6a2f5a6e675efbc845 Cr-Commit-Position: refs/heads/master@{#407289} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/cdb475af0865b21209833f6a2f5a6e675efbc845 Cr-Commit-Position: refs/heads/master@{#407289} |
