Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: sync/api/sync_change_unittest.cc

Issue 217063005: Separate SyncData methods into three groups, local, remote, and common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Remove AsLocal and AsRemote methods from SyncData. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/api/sync_change_unittest.cc
diff --git a/sync/api/sync_change_unittest.cc b/sync/api/sync_change_unittest.cc
index 8c2a7dd18bc95094958f1330181af3333d48ec7e..5f937ab7c969347f71438939245b25fbf62943c1 100644
--- a/sync/api/sync_change_unittest.cc
+++ b/sync/api/sync_change_unittest.cc
@@ -30,7 +30,7 @@ TEST_F(SyncChangeTest, LocalDelete) {
change_type,
SyncData::CreateLocalDelete(tag, PREFERENCES));
EXPECT_EQ(change_type, e.change_type());
- EXPECT_EQ(tag, e.sync_data().GetTag());
+ EXPECT_EQ(tag, SyncDataLocal(e.sync_data()).GetTag());
EXPECT_EQ(PREFERENCES, e.sync_data().GetDataType());
}
@@ -45,7 +45,7 @@ TEST_F(SyncChangeTest, LocalUpdate) {
change_type,
SyncData::CreateLocalData(tag, title, specifics));
EXPECT_EQ(change_type, e.change_type());
- EXPECT_EQ(tag, e.sync_data().GetTag());
+ EXPECT_EQ(tag, SyncDataLocal(e.sync_data()).GetTag());
EXPECT_EQ(title, e.sync_data().GetTitle());
EXPECT_EQ(PREFERENCES, e.sync_data().GetDataType());
scoped_ptr<base::DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
@@ -65,7 +65,7 @@ TEST_F(SyncChangeTest, LocalAdd) {
change_type,
SyncData::CreateLocalData(tag, title, specifics));
EXPECT_EQ(change_type, e.change_type());
- EXPECT_EQ(tag, e.sync_data().GetTag());
+ EXPECT_EQ(tag, SyncDataLocal(e.sync_data()).GetTag());
EXPECT_EQ(title, e.sync_data().GetTitle());
EXPECT_EQ(PREFERENCES, e.sync_data().GetDataType());
scoped_ptr<base::DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
« sync/api/sync_change.cc ('K') | « sync/api/sync_change.cc ('k') | sync/api/sync_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698