Separate SyncData methods into three groups, local, remote, and common.

sync/api/sync_change.cc

Index: sync/api/sync_change.cc
diff --git a/sync/api/sync_change.cc b/sync/api/sync_change.cc
index 8dedd9cb1768fbb0b3f99aebe8ae38e0cad773f7..31960a15c21689b15dd49829dc497b5d57d95967 100644
--- a/sync/api/sync_change.cc
+++ b/sync/api/sync_change.cc
@@ -31,8 +31,10 @@ bool SyncChange::IsValid() const {
   if (!sync_data_.IsLocal())
     return IsRealDataType(sync_data_.GetDataType());
 
+  SyncDataLocal sync_data_local(sync_data_);
+
   // Local changes must always have a tag and specify a valid datatype.
-  if (sync_data_.GetTag().empty() ||
+  if (sync_data_local.GetTag().empty() ||

[tim (not reviewing), 2014/03/31 23:24:24]

SyncDataLocal(sync_data_).GetTag() ?

[maniscalco, 2014/03/31 23:33:54]

Done.

       !IsRealDataType(sync_data_.GetDataType())) {
     return false;
   }