Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Issue 2170583003: Try to fix crash because of InlineBox deletion in a cached subsequence (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/line/InlineBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
index 14110df458bd481218df28a80faca8a225a8cea0..48571543ce721c39a31f4ddd183cbc2f0b68f5c0 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
@@ -67,12 +67,8 @@ void InlineBox::destroy()
if (!m_lineLayoutItem.documentBeingDestroyed()) {
setLineLayoutItemShouldDoFullPaintInvalidationIfNeeded();
-#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
- // This object may have display items in a cached subsequence, but we are
- // sure that the subsequence will be invalidated because m_lineLayoutItem has
- // been setShouldFullPaintInvalidation(), so deletion of this object is safe.
- endShouldKeepAlive();
-#endif
+ // TODO(crbug.com/619630): Make this fast.
+ m_lineLayoutItem.slowSetPaintingLayerNeedsRepaint();
}
delete this;
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698