media/midi/midi_manager.cc - Issue 2170463003: Web MIDI: Add CHECK()s to ensure MidiManager owned threads are terminated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/midi_manager.cc

Issue 2170463003: Web MIDI: Add CHECK()s to ensure MidiManager owned threads are terminated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/midi/midi_manager.cc

diff --git a/media/midi/midi_manager.cc b/media/midi/midi_manager.cc

index 12d4d0764524a5bd845e1146c942f1ec3a21cf1f..88d26600ef76ea8f2ebfe8bd1487f44b81843387 100644

--- a/media/midi/midi_manager.cc

+++ b/media/midi/midi_manager.cc

@@ -60,7 +60,7 @@ MidiManager::MidiManager()

MidiManager::~MidiManager() {

// Make sure that Finalize() is called to clean up resources allocated on

// the Chrome_IOThread.

- DCHECK(finalized_);

+ CHECK(finalized_);

Adam Goode 2016/07/21 15:40:30 Do you need to take lock_ here?

Takashi Toyoshima 2016/07/21 18:25:24 Good point. I'll fix this.

}

#if !defined(OS_MACOSX) && !defined(OS_WIN) && \

« no previous file with comments | « no previous file | media/midi/midi_manager_alsa.cc » ('j') | media/midi/midi_manager_alsa.cc » ('J')