Web MIDI: Add CHECK()s to ensure MidiManager owned threads are terminated

media/midi/midi_manager.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/midi/midi_manager.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 42 matching lines @@
 }  // namespace
 
 MidiManager::MidiManager()
     : initialized_(false), finalized_(false), result_(Result::NOT_INITIALIZED) {
   ReportUsage(Usage::CREATED);
 }
 
 MidiManager::~MidiManager() {
   // Make sure that Finalize() is called to clean up resources allocated on
   // the Chrome_IOThread.
-  DCHECK(finalized_);
+  CHECK(finalized_);

[Adam Goode, 2016/07/21 15:40:30]

Do you need to take lock_ here?

[Takashi Toyoshima, 2016/07/21 18:25:24]

Good point. I'll fix this.

 }
 
 #if !defined(OS_MACOSX) && !defined(OS_WIN) && \
     !(defined(USE_ALSA) && defined(USE_UDEV)) && !defined(OS_ANDROID)
 MidiManager* MidiManager::Create() {
   ReportUsage(Usage::CREATED_ON_UNSUPPORTED_PLATFORMS);
   return new MidiManager;
 }
 #endif
 
@@ skipping 193 matching lines @@
   base::AutoLock auto_lock(lock_);
   finalized_ = true;
 
   // Detach all clients so that they do not call MidiManager methods any more.
   for (auto* client : clients_)
     client->Detach();
 }
 
 }  // namespace midi
 }  // namespace media