Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2170433002: Revert of [turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation. (patchset #2 id:20001 of https://codereview.chromium.org/2167593002/ ) Reason for revert: Breaks arm64 gc stress: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/1605 Original issue's description: > [turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation. > > Add a dedicated simplified operator to inline the general case for the > ToBoolean conversion. In a follow up CL we will also use the ToBoolean > hints gathered by the baseline compiler. > > Committed: https://crrev.com/8c50b51ab3d21efcd2f6900d83962159f21e1590 > Cr-Commit-Position: refs/heads/master@{#37882} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/52a66bf1a87f4224c7cd100fe2fd5bdc49b583d6 Cr-Commit-Position: refs/heads/master@{#37899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -197 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 3 chunks +1 line, -154 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/representation-change.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
Created Revert of [turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation.
4 years, 5 months ago (2016-07-20 10:16:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170433002/1
4 years, 5 months ago (2016-07-20 10:16:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 10:17:04 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 10:18:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52a66bf1a87f4224c7cd100fe2fd5bdc49b583d6
Cr-Commit-Position: refs/heads/master@{#37899}

Powered by Google App Engine
This is Rietveld 408576698