Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2171373002: Revert "Enable v8 backtrace support in all debug builds" (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Enable v8 backtrace support in all debug builds" This reverts commit 3138862703079c60dcc2406dca1011fcacb4e264. BUG=chromium:630629 Committed: https://crrev.com/7883414e8b4d1646423b9a1a645a7a4ddb077c38 Cr-Commit-Position: refs/heads/master@{#37986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gni/v8.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-22 15:30:54 UTC) #4
Mark Mentovai
Adam, Jochen suggested you as a reviewer while he’s indisposed.
4 years, 5 months ago (2016-07-22 15:49:27 UTC) #8
adamk
lgtm
4 years, 5 months ago (2016-07-22 17:58:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171373002/1
4 years, 5 months ago (2016-07-22 18:11:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 18:13:15 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:15:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7883414e8b4d1646423b9a1a645a7a4ddb077c38
Cr-Commit-Position: refs/heads/master@{#37986}

Powered by Google App Engine
This is Rietveld 408576698