third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp - Issue 2170383002: CustomElements: adopt node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

Issue 2170383002: CustomElements: adopt node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout test went from bad to good, deleting failure expectation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/dom/Element.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

index 1a810a9c7ef0febf748a04a2af890c4de3d93a15..5f34f6920d36000c8a164426c39f659a43fa491e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

@@ -12,6 +12,7 @@

#include "bindings/core/v8/V8DOMWrapper.h"

#include "bindings/core/v8/V8ThrowException.h"

#include "core/dom/Document.h"

+#include "core/dom/Element.h"

#include "core/dom/ExceptionCode.h"

#include "core/dom/custom/CustomElementsRegistry.h"

#include "core/frame/LocalDOMWindow.h"

@@ -64,6 +65,7 @@ void V8HTMLElement::constructorCustom(

// TODO(davaajav): write this as one call to setCustomElementState instead of two

element->setCustomElementState(CustomElementState::Undefined);

element->setCustomElementState(CustomElementState::Custom);

+ element->setCustomElementDefinition(definition);

dominicc (has gone to gerrit) 2016/08/03 07:56:56 What do you think about setting the state to custo

} else {

element = definition->constructionStack().last();

if (element) {