CustomElements: adopt node

third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/V8HTMLElement.h"
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptCustomElementDefinition.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8BindingMacros.h"
 #include "bindings/core/v8/V8DOMWrapper.h"
 #include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/Document.h"
+#include "core/dom/Element.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/custom/CustomElementsRegistry.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 void V8HTMLElement::constructorCustom(
     const v8::FunctionCallbackInfo<v8::Value>& info)
 {
@@ skipping 32 matching lines @@
         // This is an element being created with 'new' from script
         // TODO(kojii): When HTMLElementFactory has an option not to queue
         // upgrade, call that instead of HTMLElement. HTMLElement is enough
         // for now, but type extension will require HTMLElementFactory.
         element = HTMLElement::create(
             QualifiedName(nullAtom, definition->descriptor().localName(), HTMLNames::xhtmlNamespaceURI),
             *window->document());
         // TODO(davaajav): write this as one call to setCustomElementState instead of two
         element->setCustomElementState(CustomElementState::Undefined);
         element->setCustomElementState(CustomElementState::Custom);
+        element->setCustomElementDefinition(definition);

[dominicc (has gone to gerrit), 2016/08/03 07:56:56]

What do you think about setting the state to custom in
setCustomElementDefinition? Because we should never be "custom" without a
definition.

     } else {
         element = definition->constructionStack().last();
         if (element) {
             // This is an element being upgraded that has called super
             definition->constructionStack().last().clear();
         } else {
             // During upgrade an element has invoked the same constructor
             // before calling 'super' and that invocation has poached the
             // element.
             exceptionState.throwDOMException(
@@ skipping 12 matching lines @@
     // If the element had a wrapper, we now update and return that
     // instead.
     v8SetReturnValue(info, wrapper);
 
     v8CallOrCrash(wrapper->SetPrototype(
         scriptState->context(),
         definition->prototype()));
 }
 
 } // namespace blink