Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

gpu/command_buffer/service/buffer_manager.cc

Index: gpu/command_buffer/service/buffer_manager.cc
diff --git a/gpu/command_buffer/service/buffer_manager.cc b/gpu/command_buffer/service/buffer_manager.cc
index a53b93f679d9689c34238c58013543099bca76d6..c6c9458bea91872d44eaaf5bfdb31b542ccbd2e2 100644
--- a/gpu/command_buffer/service/buffer_manager.cc
+++ b/gpu/command_buffer/service/buffer_manager.cc
@@ -21,7 +21,6 @@
 #include "gpu/command_buffer/service/memory_tracking.h"
 #include "gpu/command_buffer/service/transform_feedback_manager.h"
 #include "ui/gl/gl_bindings.h"
-#include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_version_info.h"
 #include "ui/gl/trace_util.h"
 
@@ -360,7 +359,7 @@ bool BufferManager::UseNonZeroSizeForClientSideArrayBuffer() {
 bool BufferManager::UseShadowBuffer(GLenum target, GLenum usage) {
   const bool is_client_side_array = IsUsageClientSideArray(usage);
   const bool support_fixed_attribs =
-      gl::GetGLImplementation() == gl::kGLImplementationEGLGLES2;
+      !feature_info_ || feature_info_->gl_version_info().is_es;

[no sievers, 2016/07/22 17:26:17]

|!feature_info_| is for some unit tests?
maybe worth a comment.

[piman, 2016/07/22 17:30:02]

It is (that's not ideal, but same as UseNonZeroSizeForClientSideArrayBuffer),
I'll add a comment.

[piman, 2016/07/22 19:25:37]

Done.

 
   // TODO(zmo): Don't shadow buffer data on ES3. crbug.com/491002.
   return (