Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2170183002: Don't run DirectRenderer versions of LayerTreeTest unless explicit. (Closed)

Created:
4 years, 5 months ago by danakj
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run DirectRenderer versions of LayerTreeTest unless explicit. Remove the direct variants from the SINGLE_AND_MULTI_THREAD_TEST_F macros and friends, so you will only get a DirectRenderer if you request it via SINGLE_AND_MULTI_THREAD_DIRECT_RENDERER_TEST_F and similar macros. Before, cc_unittests has 3366 tests. After, it has 3075. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/f3c49e3f36246b07f13eed92072dd7361ee0325f Cr-Commit-Position: refs/heads/master@{#407037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M cc/output/delegating_renderer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.h View 2 chunks +11 lines, -23 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
danakj
4 years, 5 months ago (2016-07-21 23:57:07 UTC) #3
danakj
4 years, 5 months ago (2016-07-21 23:57:11 UTC) #4
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-22 00:02:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170183002/1
4 years, 5 months ago (2016-07-22 00:04:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:41:59 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:44:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3c49e3f36246b07f13eed92072dd7361ee0325f
Cr-Commit-Position: refs/heads/master@{#407037}

Powered by Google App Engine
This is Rietveld 408576698