Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: tools/telemetry/support/html_output/results-template.html

Issue 217013004: Fix the incorrect Better/Worse labelling in the results page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only update the name of the variable used in the for loop. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/support/html_output/results-template.html
diff --git a/tools/telemetry/support/html_output/results-template.html b/tools/telemetry/support/html_output/results-template.html
index 2a14ce5937896c3dd9d69d5fb0b24dc3aac93099..69ad6b80bc52a512e2c6063085d9f091f6dfe003 100644
--- a/tools/telemetry/support/html_output/results-template.html
+++ b/tools/telemetry/support/html_output/results-template.html
@@ -325,9 +325,9 @@ function PerfTestMetric(name, metric, unit, isImportant) {
if (window.unitToBiggerIsBetter == undefined) {
window.unitToBiggerIsBetter = {};
var units = JSON.parse(document.getElementById('units-json').textContent);
- for (var unit in units) {
- if (units[unit].improvement_direction == 'up') {
- window.unitToBiggerIsBetter[unit] = true;
+ for (var u in units) {
+ if (units[u].improvement_direction == 'up') {
+ window.unitToBiggerIsBetter[u] = true;
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698