Fix the incorrect Better/Worse labelling in the results page.

tools/telemetry/support/html_output/results-template.html

Index: tools/telemetry/support/html_output/results-template.html
diff --git a/tools/telemetry/support/html_output/results-template.html b/tools/telemetry/support/html_output/results-template.html
index 2a14ce5937896c3dd9d69d5fb0b24dc3aac93099..f520bcb9a0223ae17965c2d17a17598ed2126652 100644
--- a/tools/telemetry/support/html_output/results-template.html
+++ b/tools/telemetry/support/html_output/results-template.html
@@ -331,7 +331,7 @@ function PerfTestMetric(name, metric, unit, isImportant) {
                 }
             }
         }
-        return window.unitToBiggerIsBetter[unit];
+        return window.unitToBiggerIsBetter[this.unit()];

[tonyg, 2014/03/31 15:10:41]

unit() calls computeScalingFactorIfNeeded(), which I think will break this
lookup -- because the table might have "ms", but the scaled unit might be "s".

Is the problem rather that the var unit in the for-loop above masks the class
wide scoped "unit"? Maybe just try changing the name of the var in the for loop
and see if it fixes your problem?

[Sébastien Marchand, 2014/03/31 16:56:05]

Changing the name of the var worked :), thanks.

     }
 }