Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2170063002: Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show… (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (patchset #3 id:40001 of https://codereview.chromium.org/2157363006/ ) Reason for revert: REverting as this broke devtools on Tip-of-tree [17701:17701:0721/140403:ERROR:CONSOLE(266)] "Uncaught (in promise) NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.", source: chrome-devtools://devtools/bundled/ui/Widget.js (266) TBR=pfeldman, dgozman NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8a8706987b18e9d2f1c380c0536203b4089d587b Cr-Commit-Position: refs/heads/master@{#406938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -96 lines) Patch
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 4 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 5 chunks +8 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 6 chunks +29 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-21 21:10:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170063002/1
4 years, 5 months ago (2016-07-21 21:10:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 21:12:13 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:15:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a8706987b18e9d2f1c380c0536203b4089d587b
Cr-Commit-Position: refs/heads/master@{#406938}

Powered by Google App Engine
This is Rietveld 408576698