Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: testing/test.gni

Issue 2169973002: Add bundle_deps to ios_{app,framework}_bundle templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-app-bundle-executable
Patch Set: Fix compilation of fat builds. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/ios/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index 0f06c6b42d101f923d7f47833fd933cffa665048..18f4f94c3630b961dd6d7edb580e77d4dd119735 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -281,7 +281,7 @@ template("test") {
_resources_bundle_data = target_name + "_resources_bundle_data"
bundle_data(_resources_bundle_data) {
- visibility = [ ":*" ]
+ visibility = [ ":$_test_target" ]
sources = [
"//testing/gtest_ios/Default.png",
]
@@ -320,12 +320,14 @@ template("test") {
deps = []
}
deps += [
- ":$_resources_bundle_data",
-
# All shared libraries must have the sanitizer deps to properly link in
# asan mode (this target will be empty in other cases).
"//build/config/sanitizers:deps",
]
+ if (!defined(bundle_deps)) {
+ bundle_deps = []
+ }
+ bundle_deps += [ ":$_resources_bundle_data" ]
}
} else {
executable(target_name) {
« no previous file with comments | « components/cronet/ios/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698