Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 2169863002: fix fuzzer bug (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix fuzzer bug Fix another fuzzer bug. Some PathOps asserts only make sense if the incoming data is well-behaved. Well-behaved tests set debugging state to trigger these additional asserts. Formalize this by creating macros similar to SkASSERT that check to see if the assert should be skipped. TBR=reed@google.com BUG=629962 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169863002 Committed: https://skia.googlesource.com/skia/+/1597628fa38d24f23ad505bfb40e70e7c8617457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -13 lines) Patch
M src/pathops/SkDConicLineIntersection.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/pathops/SkOpCoincidence.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 4 chunks +14 lines, -5 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169863002/1
4 years, 5 months ago (2016-07-21 12:33:24 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 12:48:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1597628fa38d24f23ad505bfb40e70e7c8617457

Powered by Google App Engine
This is Rietveld 408576698