Batch data use objects in ExternalDataUseObserver

chrome/browser/android/data_usage/external_data_use_reporter.cc

Index: chrome/browser/android/data_usage/external_data_use_reporter.cc
diff --git a/chrome/browser/android/data_usage/external_data_use_reporter.cc b/chrome/browser/android/data_usage/external_data_use_reporter.cc
index 898a7cbe485388776e0531c15ae2837a965f9b03..41cdfc9a72d67b870502a35b74e027a27b708902 100644
--- a/chrome/browser/android/data_usage/external_data_use_reporter.cc
+++ b/chrome/browser/android/data_usage/external_data_use_reporter.cc
@@ -130,21 +130,25 @@ ExternalDataUseReporter::~ExternalDataUseReporter() {
   DCHECK(thread_checker_.CalledOnValidThread());
 }
 
-void ExternalDataUseReporter::OnDataUse(const data_usage::DataUse& data_use) {
+void ExternalDataUseReporter::OnDataUse(
+    std::unique_ptr<std::deque<const data_usage::DataUse>> data_use_list) {
   DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(data_use_list);
 
   const base::Time now_time = base::Time::Now();
   DataUseTabModel::TrackingInfo tracking_info;
 
-  if (!data_use_tab_model_->GetTrackingInfoForTabAtTime(
-          data_use.tab_id, data_use.request_start, &tracking_info)) {
-    return;
-  }
+  for (auto data_use : *data_use_list) {

[tbansal1, 2016/07/21 04:57:11]

ALso this should be const auto &
Otherwise, a copy of data_use will be made while iterating(which is
unnecessary).

[Raj, 2016/07/21 05:58:22]

Done.

+    if (!data_use_tab_model_->GetTrackingInfoForTabAtTime(
+            data_use.tab_id, data_use.request_start, &tracking_info)) {
+      continue;
+    }
 
-  BufferDataUseReport(data_use, tracking_info.label, tracking_info.tag,
-                      previous_report_time_, now_time);
-  SubmitBufferedDataUseReport(false);
-  previous_report_time_ = now_time;
+    BufferDataUseReport(data_use, tracking_info.label, tracking_info.tag,
+                        previous_report_time_, now_time);
+    SubmitBufferedDataUseReport(false);
+    previous_report_time_ = now_time;

[tbansal1, 2016/07/21 04:40:30]

Move this outside the for loop so that it is not modified multiple times.

[Raj, 2016/07/21 05:58:22]

Done.

+  }
 }
 
 void ExternalDataUseReporter::OnReportDataUseDone(bool success) {