Batch data use objects in ExternalDataUseObserver

chrome/browser/android/data_usage/external_data_use_reporter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/data_usage/external_data_use_reporter.h"
 
 #include <utility>
 
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_base.h"
@@ skipping 112 matching lines @@
   app_state_listener_.reset(new base::android::ApplicationStatusListener(
       base::Bind(&ExternalDataUseReporter::OnApplicationStateChange,
                  base::Unretained(this))));
 #endif
 }
 
 ExternalDataUseReporter::~ExternalDataUseReporter() {
   DCHECK(thread_checker_.CalledOnValidThread());
 }
 
-void ExternalDataUseReporter::OnDataUse(const data_usage::DataUse& data_use) {
+void ExternalDataUseReporter::OnDataUse(
+    std::unique_ptr<std::deque<const data_usage::DataUse>> data_use_list) {
   DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(data_use_list);
 
   const base::Time now_time = base::Time::Now();
   DataUseTabModel::TrackingInfo tracking_info;
 
-  if (!data_use_tab_model_->GetTrackingInfoForTabAtTime(
-          data_use.tab_id, data_use.request_start, &tracking_info)) {
-    return;
+  for (auto data_use : *data_use_list) {

[tbansal1, 2016/07/21 04:57:11]

ALso this should be const auto &
Otherwise, a copy of data_use will be made while iterating(which is
unnecessary).

[Raj, 2016/07/21 05:58:22]

Done.

+    if (!data_use_tab_model_->GetTrackingInfoForTabAtTime(
+            data_use.tab_id, data_use.request_start, &tracking_info)) {
+      continue;
+    }
+
+    BufferDataUseReport(data_use, tracking_info.label, tracking_info.tag,
+                        previous_report_time_, now_time);
+    SubmitBufferedDataUseReport(false);
+    previous_report_time_ = now_time;

[tbansal1, 2016/07/21 04:40:30]

Move this outside the for loop so that it is not modified multiple times.

[Raj, 2016/07/21 05:58:22]

Done.

   }
-
-  BufferDataUseReport(data_use, tracking_info.label, tracking_info.tag,
-                      previous_report_time_, now_time);
-  SubmitBufferedDataUseReport(false);
-  previous_report_time_ = now_time;
 }
 
 void ExternalDataUseReporter::OnReportDataUseDone(bool success) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!last_data_report_submitted_ticks_.is_null());
 
   if (success) {
     RecordDataUsageReportSubmission(DATAUSAGE_REPORT_SUBMISSION_SUCCESSFUL,
                                     pending_report_bytes_);
   } else {
@@ skipping 163 matching lines @@
   hash = hash * 23 + hash_function(k.label);
   hash = hash * 31 + hash_function(k.tag);
   hash = hash * 43 + k.connection_type;
   hash = hash * 83 + hash_function(k.mcc_mnc);
   return hash;
 }
 
 }  // namespace android
 
 }  // namespace chrome