Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: infra/bots/assets/skp/create.py

Issue 2169653003: Change SKPs to new asset management format (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add --upload_to_partner_bucket flag to create.py Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/bots/assets/skp/VERSION ('k') | infra/bots/perf_skia.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/assets/skp/create.py
diff --git a/infra/bots/assets/skp/create.py b/infra/bots/assets/skp/create.py
index 68df7f07c27762d143bd4f50c69d010cdbde7e9d..6bf716c532b05d88716d7bc340c8f9996add7179 100755
--- a/infra/bots/assets/skp/create.py
+++ b/infra/bots/assets/skp/create.py
@@ -20,7 +20,8 @@ import utils
SKIA_TOOLS = os.path.join(common.INFRA_BOTS_DIR, os.pardir, os.pardir, 'tools')
-def create_asset(chrome_src_path, browser_executable, target_dir):
+def create_asset(chrome_src_path, browser_executable, target_dir,
+ upload_to_partner_bucket):
"""Create the asset."""
browser_executable = os.path.realpath(browser_executable)
chrome_src_path = os.path.realpath(chrome_src_path)
@@ -47,6 +48,8 @@ def create_asset(chrome_src_path, browser_executable, target_dir):
'--output_dir', os.getcwd(),
'--chrome_src_path', chrome_src_path,
]
+ if upload_to_partner_bucket:
+ webpages_playback_cmd.append('--upload_to_partner_bucket')
try:
subprocess.check_call(webpages_playback_cmd)
finally:
@@ -75,8 +78,10 @@ def main():
parser.add_argument('--target_dir', '-t', required=True)
parser.add_argument('--chrome_src_path', '-c', required=True)
parser.add_argument('--browser_executable', '-e', required=True)
+ parser.add_argument('--upload_to_partner_bucket', action='store_true')
args = parser.parse_args()
- create_asset(args.chrome_src_path, args.browser_executable, args.target_dir)
+ create_asset(args.chrome_src_path, args.browser_executable, args.target_dir,
+ args.upload_to_partner_bucket)
if __name__ == '__main__':
« no previous file with comments | « infra/bots/assets/skp/VERSION ('k') | infra/bots/perf_skia.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698