Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2169593002: Revert "Version 5.2.361.44 (cherry-pick)" (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2
Target Ref:
refs/pending/branch-heads/5.2
Project:
v8
Visibility:
Public.

Description

Revert "Version 5.2.361.44 (cherry-pick)" Merge fails to build. This reverts commit 6d5bfa44ecfc0bf24ef5db9c3d4ee1e3ab094189. BUG=v8:1543, v8:5174 TBR=littledan@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/d594610133f9059dc89269e6a41b2bd2cb0aa4ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/keys.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M test/mjsunit/es6/proxies-keys.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/regress/regress-5174.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
adamk
4 years, 5 months ago (2016-07-20 19:32:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d594610133f9059dc89269e6a41b2bd2cb0aa4ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698