Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: src/objects.cc

Issue 2169593002: Revert "Version 5.2.361.44 (cherry-pick)" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5.2
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/keys.cc ('k') | test/mjsunit/es6/proxies-keys.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index e86f54c6dfccacdbceedc292ea4dfbfeb0f9840f..addf97a0e41d5afec575890fcf92036bd4c019ca 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -8314,12 +8314,10 @@ MaybeHandle<FixedArray> GetOwnValuesOrEntries(Isolate* isolate,
PropertyFilter key_filter =
static_cast<PropertyFilter>(filter & ~ONLY_ENUMERABLE);
- Handle<FixedArray> keys;
- ASSIGN_RETURN_ON_EXCEPTION_VALUE(
- isolate, keys,
- KeyAccumulator::GetKeys(object, KeyCollectionMode::kOwnOnly, key_filter,
- GetKeysConversion::kConvertToString),
- MaybeHandle<FixedArray>());
+ KeyAccumulator accumulator(isolate, OWN_ONLY, key_filter);
+ MAYBE_RETURN(accumulator.CollectKeys(object, object),
+ MaybeHandle<FixedArray>());
+ Handle<FixedArray> keys = accumulator.GetKeys(CONVERT_TO_STRING);
values_or_entries = isolate->factory()->NewFixedArray(keys->length());
int length = 0;
« no previous file with comments | « src/keys.cc ('k') | test/mjsunit/es6/proxies-keys.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698