HTMLTreeBuilderSimulator: Element created inside HTMLIntegrationPoint should be HTMLElement

third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
index f5471c62e8e90530891672a07bb92fccacf7315f..56f11ff7039ec60eef893b626b9d1f9fe36ceaea 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
@@ -45,26 +45,62 @@ TEST(HTMLTreeBuilderSimulatorTest, ChangeStateInForeignContentAtHTMLIntegrationP
     EXPECT_EQ(HTMLTokenizer::DataState, tokenizer->getState())
         << "the svg start tag should have put the simulator into 'in body' "
         << "state";
+    EXPECT_TRUE(simulator.inForeignContent());
 
     startTag(token, "title");
     simulate(simulator, token, tokenizer.get()); // svg > title
     EXPECT_EQ(HTMLTokenizer::DataState, tokenizer->getState())
         << "the title start tag should not have flipped the simulator into "
         << "RCDATA state because svg is not a HTML integration point";
+    EXPECT_TRUE(simulator.inForeignContent());
 
     startTag(token, "desc");
     simulate(simulator, token, tokenizer.get()); // svg > title > desc
     EXPECT_EQ(HTMLTokenizer::DataState, tokenizer->getState())

[dominicc (has gone to gerrit), 2016/07/21 02:14:48]

I'm mildly confused comparing the code of the assertion and the description.

Just going by the name of this test,
ChangeStateInForeignContentAtHTMLIntegrationPoint, having assertions about
states and foreign content seems natural here.

The assertion code seems to be about tokenizer states. How does that relate to
HTML namespaces? Can you write an assertion that gets more directly to the
namespace question? (Maybe have both state and namespace assertions?)

-        << "the desc tag should not have flipped the simulator into the "
-        << "any unusual state because desc parsing rules do not change state, "
-        << "despite title being a HTML integration point";
+        << "the desc tag should have been created in HTML namespace";
+    EXPECT_FALSE(simulator.inForeignContent());
 
     startTag(token, "title");
     simulate(simulator, token, tokenizer.get()); // svg > title > desc > title
     EXPECT_EQ(HTMLTokenizer::RCDATAState, tokenizer->getState())
         << "the title start tag should have flipped the simulator into the "
-        << "RCDATA state for title, despite being in foreign content mode, "
-        << "because desc is a HTML integration point";
+        << "RCDATA state for title, as the desc tag should have been created "
+        << "in HTML namespace";
+    EXPECT_FALSE(simulator.inForeignContent());
+}
+
+TEST(HTMLTreeBuilderSimulatorTest, HTMLElementShouldBeCreatedInsideHTMLIntegrationPoint)
+{
+    HTMLParserOptions options;
+    HTMLTreeBuilderSimulator simulator(options);
+    std::unique_ptr<HTMLTokenizer> tokenizer = HTMLTokenizer::create(options);
+    HTMLToken token;
+
+    startTag(token, "svg");
+    simulate(simulator, token, tokenizer.get()); // open elements: svg
+    EXPECT_EQ(HTMLTokenizer::DataState, tokenizer->getState())
+        << "the svg start tag should have put the simulator into 'in body' "
+        << "state";
+
+    startTag(token, "title");
+    simulate(simulator, token, tokenizer.get()); // svg > title
+    EXPECT_EQ(HTMLTokenizer::DataState, tokenizer->getState())
+        << "the title start tag should not have flipped the simulator into "
+        << "RCDATA state because svg is not a HTML integration point";
+
+    startTag(token, "foobar");
+    simulate(simulator, token, tokenizer.get()); // svg > title > foobar
+    EXPECT_EQ(HTMLTokenizer::DataState, tokenizer->getState())
+        << "the foobar tag should have been created in HTML namespace";
+    EXPECT_FALSE(simulator.inForeignContent());
+
+    startTag(token, "title");
+    simulate(simulator, token, tokenizer.get()); // svg > title > foobar > title
+    EXPECT_EQ(HTMLTokenizer::RCDATAState, tokenizer->getState())
+        << "the title start tag should have flipped the simulator into the "
+        << "RCDATA state for title, as the foobar tag should have been created "
+        << "in HTML namespace";
+    EXPECT_FALSE(simulator.inForeignContent());
 }
 
 }